Skip to content

Commit aa32cf6

Browse files
authored
fix(s3): Notifications fail to deploy due to incompatible node runtime (#13624)
This [PR](#13488) upgraded our Node runtimes from `10` to `14`. The problem is that Node14 isn't supported for lambda functions using inline code (i.e `ZipFile`). Change to Node12 specifically for the notification handler since it's the only one using `InlineLambda`. Fixes #13620 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent e8f6267 commit aa32cf6

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

packages/@aws-cdk/aws-lambda-event-sources/test/integ.s3.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@
185185
"Arn"
186186
]
187187
},
188-
"Runtime": "nodejs14.x",
188+
"Runtime": "nodejs12.x",
189189
"Timeout": 300
190190
},
191191
"DependsOn": [

packages/@aws-cdk/aws-s3-notifications/test/integ.notifications.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@
220220
"Arn"
221221
]
222222
},
223-
"Runtime": "nodejs14.x",
223+
"Runtime": "nodejs12.x",
224224
"Timeout": 300
225225
},
226226
"DependsOn": [

packages/@aws-cdk/aws-s3-notifications/test/lambda/integ.bucket-notifications.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@
244244
"Arn"
245245
]
246246
},
247-
"Runtime": "nodejs14.x",
247+
"Runtime": "nodejs12.x",
248248
"Timeout": 300
249249
},
250250
"DependsOn": [

packages/@aws-cdk/aws-s3-notifications/test/sns/integ.sns-bucket-notifications.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@
203203
"Arn"
204204
]
205205
},
206-
"Runtime": "nodejs14.x",
206+
"Runtime": "nodejs12.x",
207207
"Timeout": 300
208208
},
209209
"DependsOn": [

packages/@aws-cdk/aws-s3-notifications/test/sqs/integ.bucket-notifications.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
"Arn"
193193
]
194194
},
195-
"Runtime": "nodejs14.x",
195+
"Runtime": "nodejs12.x",
196196
"Timeout": 300
197197
},
198198
"DependsOn": [

packages/@aws-cdk/aws-s3/lib/notifications-resource/notifications-resource-handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export class NotificationsResourceHandler extends Construct {
8282
Code: { ZipFile: `exports.handler = ${handler.toString()};` },
8383
Handler: 'index.handler',
8484
Role: role.roleArn,
85-
Runtime: 'nodejs14.x',
85+
Runtime: 'nodejs12.x',
8686
Timeout: 300,
8787
},
8888
});

0 commit comments

Comments
 (0)