Skip to content

Commit 2a032ea

Browse files
authored
chore: remove strong-named key references and signing for .NET (#12632)
The benefits of strong-name signing assemblies are marginal at best, and it turns out we actually weren't strong-name signing our assemblies anyway, making all of this extra infrastructure unnecessary. This removes the strong-name key (SNK) prebuild script, updates the buildspec to remove the reference to it, and removes the linter rule that enforced the strong-named assembly properties. Prior to removal, the rule was reversed and used to update the package.json files. This change will be accompanied by a change to our pipeline definition to remove the references on that side. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 6be5a92 commit 2a032ea

File tree

185 files changed

+2
-464
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

185 files changed

+2
-464
lines changed

buildspec.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ phases:
1212

1313
# Install yarn if it wasn't already present in the image
1414
- yarn --version || npm -g install yarn
15-
pre_build:
16-
commands:
17-
- /bin/bash ./fetch-dotnet-snk.sh
1815
build:
1916
commands:
2017
- 'if ${BUMP_CANDIDATE:-false}; then /bin/bash ./scripts/bump-candidate.sh; fi'

fetch-dotnet-snk.sh

Lines changed: 0 additions & 60 deletions
This file was deleted.

packages/@aws-cdk/alexa-ask/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
"dotnet": {
1111
"namespace": "Amazon.CDK.Alexa.Ask",
1212
"packageId": "Amazon.CDK.Alexa.Ask",
13-
"signAssembly": true,
14-
"assemblyOriginatorKeyFile": "../../key.snk",
1513
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
1614
},
1715
"java": {

packages/@aws-cdk/app-delivery/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
"dotnet": {
1717
"namespace": "Amazon.CDK.AppDelivery",
1818
"packageId": "Amazon.CDK.AppDelivery",
19-
"signAssembly": true,
20-
"assemblyOriginatorKeyFile": "../../key.snk",
2119
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
2220
},
2321
"python": {

packages/@aws-cdk/assets/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
"dotnet": {
1818
"namespace": "Amazon.CDK.Assets",
1919
"packageId": "Amazon.CDK.Assets",
20-
"signAssembly": true,
21-
"assemblyOriginatorKeyFile": "../../key.snk",
2220
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
2321
},
2422
"python": {

packages/@aws-cdk/aws-accessanalyzer/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
"dotnet": {
1111
"namespace": "Amazon.CDK.AWS.AccessAnalyzer",
1212
"packageId": "Amazon.CDK.AWS.AccessAnalyzer",
13-
"signAssembly": true,
14-
"assemblyOriginatorKeyFile": "../../key.snk",
1513
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
1614
},
1715
"java": {

packages/@aws-cdk/aws-acmpca/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
"dotnet": {
1111
"namespace": "Amazon.CDK.AWS.ACMPCA",
1212
"packageId": "Amazon.CDK.AWS.ACMPCA",
13-
"signAssembly": true,
14-
"assemblyOriginatorKeyFile": "../../key.snk",
1513
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
1614
},
1715
"java": {

packages/@aws-cdk/aws-amazonmq/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
"dotnet": {
1111
"namespace": "Amazon.CDK.AWS.AmazonMQ",
1212
"packageId": "Amazon.CDK.AWS.AmazonMQ",
13-
"signAssembly": true,
14-
"assemblyOriginatorKeyFile": "../../key.snk",
1513
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
1614
},
1715
"java": {

packages/@aws-cdk/aws-amplify/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
"dotnet": {
1111
"namespace": "Amazon.CDK.AWS.Amplify",
1212
"packageId": "Amazon.CDK.AWS.Amplify",
13-
"signAssembly": true,
14-
"assemblyOriginatorKeyFile": "../../key.snk",
1513
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
1614
},
1715
"java": {

packages/@aws-cdk/aws-apigateway/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
"dotnet": {
1818
"namespace": "Amazon.CDK.AWS.APIGateway",
1919
"packageId": "Amazon.CDK.AWS.APIGateway",
20-
"signAssembly": true,
21-
"assemblyOriginatorKeyFile": "../../key.snk",
2220
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png"
2321
},
2422
"python": {

0 commit comments

Comments
 (0)