Skip to content

Commit 06b8a54

Browse files
authored
Merge branch 'master' into epolon/fix-nested-stack-params-integ-test
2 parents e1c6239 + 87860ca commit 06b8a54

39 files changed

+533
-253
lines changed

allowed-breaking-changes.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,6 @@ incompatible-argument:@aws-cdk/aws-iam.PrincipalPolicyFragment.<initializer>
4949
changed-type:@aws-cdk/aws-iam.FederatedPrincipal.conditions
5050
changed-type:@aws-cdk/aws-iam.PrincipalPolicyFragment.conditions
5151
changed-type:@aws-cdk/aws-iam.PrincipalWithConditions.conditions
52+
# Changing untyped property blob into typed property blob
53+
change-return-type:@aws-cdk/cloud-assembly-schema.Manifest.load
54+
incompatible-argument:@aws-cdk/cloud-assembly-schema.Manifest.save

packages/@aws-cdk/aws-cloudformation/test/test.nested-stack.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,7 @@ export = {
912912
const app = new App();
913913
const stack = new Stack(app, 'ParentStack', { env: { account: '1234account', region: 'us-east-44' } });
914914
const nestedStack = new NestedStack(stack, 'nested');
915-
const provider = 'dummyProvider';
915+
const provider = 'availability-zones';
916916
const expectedKey = ContextProvider.getKey(nestedStack, {
917917
provider,
918918
}).key;

packages/@aws-cdk/aws-ec2/lib/machine-image.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as ssm from '@aws-cdk/aws-ssm';
2+
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
23
import { Construct, ContextProvider, Stack, Token } from '@aws-cdk/core';
34
import * as cxapi from '@aws-cdk/cx-api';
45
import { UserData } from './user-data';
@@ -416,11 +417,11 @@ export class LookupMachineImage implements IMachineImage {
416417
Object.assign(filters, this.props.filters);
417418

418419
const value = ContextProvider.getValue(scope, {
419-
provider: cxapi.AMI_PROVIDER,
420+
provider: cxschema.ContextProvider.AMI_PROVIDER,
420421
props: {
421422
owners: this.props.owners,
422423
filters,
423-
} as cxapi.AmiContextQuery,
424+
} as cxschema.AmiContextQuery,
424425
dummyValue: 'ami-1234',
425426
}).value as cxapi.AmiContextResponse;
426427

packages/@aws-cdk/aws-ec2/lib/vpc.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
12
import { ConcreteDependable, Construct, ContextProvider, DependableTrait, IConstruct,
23
IDependable, IResource, Lazy, Resource, Stack, Tag, Token } from '@aws-cdk/core';
34
import * as cxapi from '@aws-cdk/cx-api';
@@ -1008,12 +1009,12 @@ export class Vpc extends VpcBase {
10081009
}
10091010

10101011
const attributes: cxapi.VpcContextResponse = ContextProvider.getValue(scope, {
1011-
provider: cxapi.VPC_PROVIDER,
1012+
provider: cxschema.ContextProvider.VPC_PROVIDER,
10121013
props: {
10131014
filter,
10141015
returnAsymmetricSubnets: true,
10151016
subnetGroupNameTag: options.subnetGroupNameTag,
1016-
} as cxapi.VpcContextQuery,
1017+
} as cxschema.VpcContextQuery,
10171018
dummyValue: undefined,
10181019
}).value;
10191020

packages/@aws-cdk/aws-ec2/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
"@aws-cdk/aws-ssm": "0.0.0",
8080
"@aws-cdk/core": "0.0.0",
8181
"@aws-cdk/cx-api": "0.0.0",
82+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
8283
"@aws-cdk/region-info": "0.0.0",
8384
"constructs": "^3.0.2"
8485
},
@@ -91,6 +92,7 @@
9192
"@aws-cdk/aws-ssm": "0.0.0",
9293
"@aws-cdk/core": "0.0.0",
9394
"@aws-cdk/cx-api": "0.0.0",
95+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
9496
"@aws-cdk/region-info": "0.0.0",
9597
"constructs": "^3.0.2"
9698
},

packages/@aws-cdk/aws-ec2/test/test.vpc.from-lookup.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
12
import { Construct, ContextProvider, GetContextValueOptions, GetContextValueResult, Lazy, Stack } from '@aws-cdk/core';
23
import * as cxapi from '@aws-cdk/cx-api';
34
import { Test } from 'nodeunit';
@@ -218,12 +219,12 @@ interface MockVcpContextResponse {
218219

219220
function mockVpcContextProviderWith(
220221
test: Test, response: MockVcpContextResponse,
221-
paramValidator?: (options: cxapi.VpcContextQuery) => void) {
222+
paramValidator?: (options: cxschema.VpcContextQuery) => void) {
222223
const previous = ContextProvider.getValue;
223224
ContextProvider.getValue = (_scope: Construct, options: GetContextValueOptions) => {
224225
// do some basic sanity checks
225-
test.equal(options.provider, cxapi.VPC_PROVIDER,
226-
`Expected provider to be: '${cxapi.VPC_PROVIDER}', got: '${options.provider}'`);
226+
test.equal(options.provider, cxschema.ContextProvider.VPC_PROVIDER,
227+
`Expected provider to be: '${cxschema.ContextProvider.VPC_PROVIDER}', got: '${options.provider}'`);
227228
test.equal((options.props || {}).returnAsymmetricSubnets, true,
228229
`Expected options.props.returnAsymmetricSubnets to be true, got: '${(options.props || {}).returnAsymmetricSubnets}'`);
229230

packages/@aws-cdk/aws-route53/lib/hosted-zone.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as ec2 from '@aws-cdk/aws-ec2';
2+
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
23
import { Construct, ContextProvider, Duration, Lazy, Resource, Stack } from '@aws-cdk/core';
3-
import * as cxapi from '@aws-cdk/cx-api';
44
import { HostedZoneProviderProps } from './hosted-zone-provider';
55
import { HostedZoneAttributes, IHostedZone } from './hosted-zone-ref';
66
import { CaaAmazonRecord, ZoneDelegationRecord } from './record-set';
@@ -107,7 +107,7 @@ export class HostedZone extends Resource implements IHostedZone {
107107
}
108108

109109
const response: HostedZoneContextResponse = ContextProvider.getValue(scope, {
110-
provider: cxapi.HOSTED_ZONE_PROVIDER,
110+
provider: cxschema.ContextProvider.HOSTED_ZONE_PROVIDER,
111111
dummyValue: DEFAULT_HOSTED_ZONE,
112112
props: query,
113113
}).value;

packages/@aws-cdk/aws-route53/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@
7575
"@aws-cdk/aws-ec2": "0.0.0",
7676
"@aws-cdk/aws-logs": "0.0.0",
7777
"@aws-cdk/core": "0.0.0",
78-
"@aws-cdk/cx-api": "0.0.0",
78+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
7979
"constructs": "^3.0.2"
8080
},
8181
"homepage": "https://github.com/aws/aws-cdk",
8282
"peerDependencies": {
8383
"@aws-cdk/aws-ec2": "0.0.0",
8484
"@aws-cdk/aws-logs": "0.0.0",
8585
"@aws-cdk/core": "0.0.0",
86-
"@aws-cdk/cx-api": "0.0.0",
86+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
8787
"constructs": "^3.0.2"
8888
},
8989
"engines": {

packages/@aws-cdk/aws-ssm/lib/parameter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import * as iam from '@aws-cdk/aws-iam';
22
import * as kms from '@aws-cdk/aws-kms';
3+
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
34
import {
45
CfnDynamicReference, CfnDynamicReferenceService, CfnParameter,
56
Construct, ContextProvider, Fn, IResource, Resource, Stack, Token,
67
} from '@aws-cdk/core';
7-
import * as cxapi from '@aws-cdk/cx-api';
88
import * as ssm from './ssm.generated';
99
import { arnForParameterName, AUTOGEN_MARKER } from './util';
1010

@@ -362,7 +362,7 @@ export class StringParameter extends ParameterBase implements IStringParameter {
362362
*/
363363
public static valueFromLookup(scope: Construct, parameterName: string): string {
364364
const value = ContextProvider.getValue(scope, {
365-
provider: cxapi.SSM_PARAMETER_PROVIDER,
365+
provider: cxschema.ContextProvider.SSM_PARAMETER_PROVIDER,
366366
props: { parameterName },
367367
dummyValue: `dummy-value-for-${parameterName}`,
368368
}).value;

packages/@aws-cdk/aws-ssm/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@
7474
"@aws-cdk/aws-iam": "0.0.0",
7575
"@aws-cdk/aws-kms": "0.0.0",
7676
"@aws-cdk/core": "0.0.0",
77-
"@aws-cdk/cx-api": "0.0.0",
77+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
7878
"constructs": "^3.0.2"
7979
},
8080
"homepage": "https://github.com/aws/aws-cdk",
8181
"peerDependencies": {
8282
"@aws-cdk/aws-iam": "0.0.0",
8383
"@aws-cdk/aws-kms": "0.0.0",
8484
"@aws-cdk/core": "0.0.0",
85-
"@aws-cdk/cx-api": "0.0.0",
85+
"@aws-cdk/cloud-assembly-schema": "0.0.0",
8686
"constructs": "^3.0.2"
8787
},
8888
"engines": {

0 commit comments

Comments
 (0)