fix(cli): running --telemetry-file without the --unstable option creates a telemetry file
#731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
commented
Jul 23, 2025
| throw new ToolkitError('You must either specify a list of Stacks or the `--all` argument'); | ||
| } | ||
|
|
||
| if (args['telemetry-file'] && !configuration.settings.get(['unstable']).includes('telemetry')) { |
Contributor
Author
There was a problem hiding this comment.
This is too late in the process because telemetry has already been initialized, and the error thrown is then considered as a telemetry event.
We should really structure the unstable protection mechanism better.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 81.05% 81.00% -0.05%
==========================================
Files 61 61
Lines 8007 8007
Branches 900 898 -2
==========================================
- Hits 6490 6486 -4
- Misses 1497 1501 +4
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is currently unstable, so it shouldn't apply at all if invoked without the
--unstableflag.Right now, it creates a telemetry file with an event indicating the aforementioned failure.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license