Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make generate-limits script failed due to ENI limit mismatch #2906

Closed
ytsssun opened this issue May 3, 2024 · 3 comments
Closed

make generate-limits script failed due to ENI limit mismatch #2906

ytsssun opened this issue May 3, 2024 · 3 comments
Labels

Comments

@ytsssun
Copy link

ytsssun commented May 3, 2024

What happened:
I am getting error when running make generate-limits.

A previous region has different limits for instanceType=c6in.32xlarge than region=ap-south-1

Attach logs

Full log:

{"level":"info","ts":"2024-05-03T22:24:57.229Z","caller":"/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51","msg":"Describing instance types in region=ap-northeast-1"}
{"level":"info","ts":"2024-05-03T22:25:00.001Z","caller":"/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51","msg":"Describing instance types in region=ap-northeast-2"}
{"level":"info","ts":"2024-05-03T22:25:01.684Z","caller":"/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51","msg":"Describing instance types in region=ap-northeast-3"}
{"level":"info","ts":"2024-05-03T22:25:02.829Z","caller":"/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51","msg":"Describing instance types in region=ap-south-1"}
{"level":"fatal","ts":"2024-05-03T22:25:04.973Z","caller":"/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51","msg":"A previous region has different limits for instanceType=c6in.32xlarge than region=ap-south-1","stacktrace":"github.com/aws/amazon-vpc-cni-k8s/pkg/utils/logger.(*structuredLogger).Fatalf\n\t/home/ec2-user/amazon-vpc-cni-k8s/pkg/utils/logger/zaplogger.go:83\nmain.describeInstanceTypes\n\t/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:178\nmain.main\n\t/home/ec2-user/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:51\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:250"}
exit status 1

What you expected to happen:
Expect the script to run successfully and generate the eni-max-pods.txt.

How to reproduce it (as minimally and precisely as possible):
Can be easily reproduced by running the make generate-limits command.

Anything else we need to know?:
This is currently blocking Bottlerocket 1.20.0 release (bottlerocket-os/bottlerocket#3942)

Environment:

  • Kubernetes version (use kubectl version): N/A
  • CNI Version: N/A
  • OS (e.g: cat /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
@orsenthil
Copy link
Member

This report looks like the instance c6in.32xlarge does have the same maxENI value depending on the region, which is very strange.

The error being thrown is intentional to capture these issues, and it was introduced in this PR
https://github.com/aws/amazon-vpc-cni-k8s/pull/1846/files

@ytsssun
Copy link
Author

ytsssun commented May 7, 2024

Issue is resolved, I was able to generate a eni-max-pods file today. Looks like root cause is not with the script. Thanks!

@ytsssun ytsssun closed this as completed May 7, 2024
Copy link

github-actions bot commented May 7, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants