Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/amazon-ecs-agent
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c61e2fc6882edad7a8b76b1a27c5f386a66f7f9e
Choose a base ref
..
head repository: aws/amazon-ecs-agent
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 35ce02564e3209424be5639d8d9869efe40747f5
Choose a head ref
Showing with 2 additions and 2 deletions.
  1. +2 −2 agent/ecscni/namespace_helper_windows.go
4 changes: 2 additions & 2 deletions agent/ecscni/namespace_helper_windows.go
Original file line number Diff line number Diff line change
@@ -102,8 +102,8 @@ func (nsHelper *helper) ConfigureTaskNamespaceRouting(ctx context.Context, taskE
// Invoke the generated commands inside the task namespace.
// On Windows 2004 and 20H2, there are a few stdout messages which leads to the failure of the tasks.
// By using &, we ensure that the commands are executed irrespectively. In case of error, the
// other commands can be executed and the error would be reported to agent. Since the agent will
// kill the task, execution of other independent commands is immaterial.
// other commands can be executed (all commands are independent of each other) and the error would be
// reported to agent. Since the agent will kill the task, execution of other commands is immaterial.
err := nsHelper.invokeCommandsInsideContainer(ctx, config.ContainerID, commands, " & ")
if err != nil {
return errors.Wrapf(err, "failed to execute commands inside task namespace")