Skip to content

Commit 76dd8ed

Browse files
shubham2892ubhattacharjya
authored andcommitted
replace device list argument with task stats device
1 parent 52bc1a9 commit 76dd8ed

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

agent/stats/task_linux.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,7 @@ func (taskStat *StatsTask) collect() {
124124

125125
func (taskStat *StatsTask) processStatsStream() error {
126126
taskArn := taskStat.TaskMetadata.TaskArn
127-
awsvpcNetworkStats, errC := taskStat.getAWSVPCNetworkStats(taskStat.TaskMetadata.DeviceName,
128-
taskStat.TaskMetadata.ContainerPID, taskStat.TaskMetadata.NumberContainers)
127+
awsvpcNetworkStats, errC := taskStat.getAWSVPCNetworkStats()
129128

130129
returnError := false
131130
for {
@@ -203,18 +202,16 @@ func linkStatsToDockerStats(netLinkStats *netlinklib.LinkStatistics, numberOfCon
203202
return networkStats
204203
}
205204

206-
func (taskStat *StatsTask) getAWSVPCNetworkStats(deviceList []string, containerPID string,
207-
numberOfContainers int) (<-chan *types.StatsJSON, <-chan error) {
205+
func (taskStat *StatsTask) getAWSVPCNetworkStats() (<-chan *types.StatsJSON, <-chan error) {
208206

209207
errC := make(chan error)
210208
statsC := make(chan *dockerstats.StatsJSON)
211-
if numberOfContainers > 0 {
209+
if taskStat.TaskMetadata.NumberContainers > 0 {
212210
go func() {
213211
defer close(statsC)
214212
statPollTicker := time.NewTicker(taskStat.metricPublishInterval)
215213
defer statPollTicker.Stop()
216214
for range statPollTicker.C {
217-
networkStats := make(map[string]dockerstats.NetworkStats, len(deviceList))
218215
if len(taskStat.TaskMetadata.DeviceName) == 0 {
219216
var err error
220217
taskStat.TaskMetadata.DeviceName, err = taskStat.populateNIDeviceList(taskStat.TaskMetadata.ContainerPID)
@@ -223,9 +220,11 @@ func (taskStat *StatsTask) getAWSVPCNetworkStats(deviceList []string, containerP
223220
return
224221
}
225222
}
226-
for _, device := range deviceList {
223+
networkStats := make(map[string]dockerstats.NetworkStats, len(taskStat.TaskMetadata.DeviceName))
224+
for _, device := range taskStat.TaskMetadata.DeviceName {
227225
var link netlinklib.Link
228-
err := taskStat.nswrapperinterface.WithNetNSPath(fmt.Sprintf(ecscni.NetnsFormat, containerPID),
226+
err := taskStat.nswrapperinterface.WithNetNSPath(fmt.Sprintf(ecscni.NetnsFormat,
227+
taskStat.TaskMetadata.ContainerPID),
229228
func(ns.NetNS) error {
230229
var linkErr error
231230
if link, linkErr = taskStat.netlinkinterface.LinkByName(device); linkErr != nil {
@@ -239,7 +238,8 @@ func (taskStat *StatsTask) getAWSVPCNetworkStats(deviceList []string, containerP
239238
return
240239
}
241240
netLinkStats := link.Attrs().Statistics
242-
networkStats[link.Attrs().Name] = linkStatsToDockerStats(netLinkStats, uint64(numberOfContainers))
241+
networkStats[link.Attrs().Name] = linkStatsToDockerStats(netLinkStats,
242+
uint64(taskStat.TaskMetadata.NumberContainers))
243243
}
244244

245245
dockerStats := &types.StatsJSON{

0 commit comments

Comments
 (0)