Skip to content

Commit 73b6c31

Browse files
fierlionshubham2892
authored andcommitted
Revert "update v4 metadata to return network stats despite missing stats for single container (#2719)"
This reverts commit 7a82ee7.
1 parent 35b06d8 commit 73b6c31

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

Diff for: agent/handlers/v4/task_metadata_handler.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,12 @@ func TaskMetadataHandler(state dockerstate.TaskEngineState, ecsClient api.ECSCli
6565
for _, containerResponse := range taskResponse.Containers {
6666
networks, err := GetContainerNetworkMetadata(containerResponse.ID, state)
6767
if err != nil {
68-
seelog.Warnf("Error retrieving network metadata for container %s - %s", containerResponse.ID, err)
68+
errResponseJSON, err := json.Marshal(err.Error())
69+
if e := utils.WriteResponseIfMarshalError(w, err); e != nil {
70+
return
71+
}
72+
utils.WriteJSONToResponse(w, http.StatusInternalServerError, errResponseJSON, utils.RequestTypeContainerMetadata)
73+
return
6974
}
7075
containerResponse.Networks = networks
7176
responses = append(responses, containerResponse)

0 commit comments

Comments
 (0)