File tree 1 file changed +8
-4
lines changed
1 file changed +8
-4
lines changed Original file line number Diff line number Diff line change @@ -23,10 +23,14 @@ const (
23
23
ListImagesTimeout = 10 * time .Minute
24
24
// LoadImageTimeout is the timeout for the LoadImage API. It's set
25
25
// to much lower value than pullImageTimeout as it involves loading
26
- // image from either a file or STDIN
27
- // calls involved.
28
- // TODO: Benchmark and re-evaluate this value
29
- LoadImageTimeout = 10 * time .Minute
26
+ // image from either a file or STDIN calls involved.
27
+ // This value is set based on benchmarking the time of loading the pause container image,
28
+ // since it's currently only used to load that image. If this is to be used to load any
29
+ // other image in the future, additional benchmarking will be required.
30
+ // Per benchmark, 2 min is roughly 4x of the worst case (29s) across 400 image loads on
31
+ // al1/al2/al2gpu/al2arm with smallest instance type available (t2.nano/a1.medium) and
32
+ // burst balance = 0.
33
+ LoadImageTimeout = 2 * time .Minute
30
34
// RemoveImageTimeout is the timeout for the RemoveImage API.
31
35
RemoveImageTimeout = 3 * time .Minute
32
36
You can’t perform that action at this time.
0 commit comments