Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15 - Only approved models trigger the deployment pipeline #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zoltan-fedor
Copy link

This fixes #15.

Based on the design of mlops-template-gitlab, the model deployment pipeline should only be triggered for 'Approved' models.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…peline - `mlops-template-gitlab`

This fixes aws-samples#15.

Based on the design of `mlops-template-gitlab`, the model deployment pipeline should only be triggered for 'Approved' models.
@kirit93
Copy link
Contributor

kirit93 commented May 17, 2022

Will this design ensure the CI/CD pipeline for deployment will be triggered when models are moved from "Approved" to "Rejected"? The 1P templates roll-back the endpoint to the latest approved model if the deployed model's status changes to "Rejected".

@zoltan-fedor
Copy link
Author

The CI/CD pipeline only gets triggered when the model moves to "Approved". Once it is "Approved" the pipeline is already triggered. You can't "untrigger" it by moving it to "Rejected" from "Approved".
A model being in "Pending" should either go to "Approved" or "Rejected" and not first to "Approved" and then to "Rejected". I don't really see why would you approve a model first just to reject it later.

If you have a valid use-case to have models move from "Approved" to "Rejected", then you will need to extend the design to re-trigger an event to trigger the CI/CD when a model gets rejected and so the latest approved model re-triggers the deployment pipeline.

@kirit93
Copy link
Contributor

kirit93 commented Jun 14, 2022

What if you "Approve" a model, it's performance starts to drift, and you need to roll back to a previous version of the model? Changing the state to "Rejected" should allow you to trigger an automated rollback.

@zoltan-fedor
Copy link
Author

Sure, feel free to make a PR for that.
What is certain, that a non-approved model should NOT proceed to deployment - which is what this PR fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unapproved models do trigger the deployment pipeline - mlops-template-gitlab
2 participants