Skip to content

Commit ee91f30

Browse files
nija-atmergify[bot]
authored andcommitted
fix: broken build (#225)
The resource-overrides code build was broken because desiredCapacity is not calculated all of the time. Ref: aws/aws-cdk@0adf6c7#diff-ab28b1e5c6b252f017045680eb86f108 Also, outputting the current project being built into STDOUT for better future diagnosis.
1 parent e834205 commit ee91f30

File tree

4 files changed

+3
-1
lines changed

4 files changed

+3
-1
lines changed

java/resource-overrides/src/test/resources/software/amazon/awscdk/examples/testResourceOverrides.expected.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@
373373
"Properties": {
374374
"MaxSize": "1",
375375
"MinSize": "1",
376-
"DesiredCapacity": "1",
377376
"LaunchConfigurationName": {
378377
"Ref": "ASGLaunchConfigC00AF12B"
379378
},

scripts/build-java.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ npm install
1010
for pomFile in $(find $scriptdir/../java -name pom.xml); do
1111
(
1212
cd $(dirname $pomFile)
13+
echo "Building project at $(dirname $pomFile)"
1314
mvn compile test
1415

1516
$scriptdir/synth.sh

scripts/build-npm.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ verify_star_dependencies() {
2222
# Find and build all NPM projects
2323
for pkgJson in $(find typescript -name package.json | grep -v node_modules); do
2424
(
25+
echo "Building project at $(dirname $pkgJson)"
2526
cd $(dirname $pkgJson)
2627

2728
if [[ -f DO_NOT_AUTOTEST ]]; then exit 0; fi

scripts/build-python.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ for requirements in $(find $scriptdir/../python -name requirements.txt -not -pa
1616
echo "=============================="
1717

1818
cd $(dirname $requirements)
19+
echo "Building project at $(dirname $requirements)"
1920
[[ ! -f DO_NOT_AUTOTEST ]] || exit 0
2021

2122
source /tmp/.venv/bin/activate

0 commit comments

Comments
 (0)