Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: poetry-core changed build behaviour #2012

Closed
sthulb opened this issue Mar 15, 2023 · 2 comments
Closed

Bug: poetry-core changed build behaviour #2012

sthulb opened this issue Mar 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working internal Maintenance changes

Comments

@sthulb
Copy link
Contributor

sthulb commented Mar 15, 2023

Expected Behaviour

When we run poetry build a setup.py file should be generated

Current Behaviour

Because of a behaviour change in poetry-core (python-poetry/poetry-core#318), PT no longer generates a setup.py file and this breaks for downstream users.

Code snippet

N/A

Possible Solution

add:

[tool.poetry.build]
generate-setup-file = true

to the pyproject.toml

Steps to Reproduce

  1. poetry build
  2. inspect dist for setup.py

AWS Lambda Powertools for Python version

latest

AWS Lambda function runtime

3.6

Packaging format used

PyPi

Debugging logs

No response

@sthulb sthulb added bug Something isn't working triage Pending triage from maintainers labels Mar 15, 2023
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Mar 15, 2023
@heitorlessa
Copy link
Contributor

PT no longer generates a setup.py file and this breaks for downstream users.

For downstream users using custom build tools that depend on setup.py being present. :)

@heitorlessa heitorlessa added the internal Maintenance changes label Mar 15, 2023
@heitorlessa heitorlessa added the pending-release Fix or implementation already in dev waiting to be released label Mar 15, 2023
@github-actions
Copy link
Contributor

This is now released under 2.10.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Maintenance changes
Projects
None yet
Development

No branches or pull requests

2 participants