Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial metrics implementation #7

Merged
merged 10 commits into from
Oct 13, 2020
Merged

feat: Initial metrics implementation #7

merged 10 commits into from
Oct 13, 2020

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Sep 14, 2020

Description of changes:

Added support for 2 types of metrics:

  • SingleMetric - Encapsulated in using clause, metric is automatically flushed to cloudwatch when SingleMetric object is released.
  • Metrics - Metrics are persisted in memory until the developer manually flushes them using code or when the EMF enforced metric limit is reached - 100 metrics per EMF object.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@msimpsonnz
Copy link
Contributor

Looks great, do you have any tests?

msimpsonnz
msimpsonnz approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@msimpsonnz msimpsonnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, once we have figured more out about implementation we will need some tests

libraries/src/Amazon.LambdaPowertools.Metrics/MetricsManager.cs Outdated Show resolved Hide resolved
@sliedig sliedig merged commit f3aa1d8 into aws-powertools:develop Oct 13, 2020
@heitorlessa
Copy link
Contributor

heitorlessa commented Oct 13, 2020 via email

@t1agob t1agob added area/metrics Core metrics utility feature New features or minor changes labels Jan 18, 2022
@t1agob t1agob changed the title feature: metrics feat: metrics Jan 18, 2022
@t1agob t1agob changed the title feat: metrics feat: Initial metrics implementation Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrm pgrm pgrm left review comments

@msimpsonnz msimpsonnz msimpsonnz approved these changes

@sliedig sliedig Awaiting requested review from sliedig

Assignees
No one assigned
Labels
area/metrics Core metrics utility feature New features or minor changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t1agob @msimpsonnz @heitorlessa @pgrm @sliedig