Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Idempotency - refactor example to be simpler with a comparable idempotent output #342

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 4, 2023

Please provide the issue number

Issue number: #300

Summary

Change Idempotency example to be simpler and with a comparable output using a Guid to test idempotency.
The method was extracted to provide a method to test future implementation of Idempotency in a method.

Changes

Please provide a summary of what's being changed

Refactor example to be simpler and with a comparable Idempotent example Guid.
Update dependencies.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig July 4, 2023 17:32
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 4, 2023
@hjgraca hjgraca added documentation Improvements or additions to documentation area/idempotency labels Jul 4, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jul 4, 2023
@hjgraca hjgraca changed the title chore: Refactor example to be simpler and with a comparable Idempotent example chore: Idempotency - refactor example to be simpler with a comparable idempotent output Jul 5, 2023
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 6165b51 into aws-powertools:develop Jul 14, 2023
@hjgraca hjgraca deleted the idempotency-simpler-example branch July 14, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency documentation Improvements or additions to documentation internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants