Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update PowertoolsEnvironmentTest.cs #255

Merged
merged 1 commit into from
May 5, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented May 5, 2023

Please provide the issue number

Issue number: #213

Summary

Changes

Remove real tests against environment variables

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from sliedig May 5, 2023 11:22
@hjgraca hjgraca changed the title fix - Update PowertoolsEnvironmentTest.cs fix: Update PowertoolsEnvironmentTest.cs May 5, 2023
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label May 5, 2023
@amirkaws amirkaws requested review from amirkaws and removed request for sliedig May 5, 2023 11:24
@hjgraca hjgraca assigned hjgraca and unassigned amirkaws May 5, 2023
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirkaws amirkaws merged commit 01de762 into develop May 5, 2023
@amirkaws amirkaws deleted the fix-remove-real-env-tests branch May 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants