Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong metrics timestamp #209

Merged

Conversation

amirkaws
Copy link
Contributor

Please provide the issue number

Issue number: 207

Summary

This PR addresses the incorrect metrics timestamp

Changes

Please provide a summary of what's being changed

Timestamp for the context has change to generate a new time every time context flushes and serialises EMF metrics to CloudWatch logs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from sliedig February 14, 2023 17:14
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Feb 14, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 56.35% // Head: 56.35% // No change to project coverage 👍

Coverage data is based on head (636de73) compared to base (f854e95).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #209   +/-   ##
========================================
  Coverage    56.35%   56.35%           
========================================
  Files           41       41           
  Lines         1778     1778           
========================================
  Hits          1002     1002           
  Misses         776      776           
Flag Coverage Δ
unittests 56.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/AWS.Lambda.Powertools.Metrics/Model/Metadata.cs 97.91% <100.00%> (-0.05%) ⬇️
...ls.Metrics/Serializer/JsonNamingPolicyDecorator.cs 57.14% <0.00%> (ø)
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 91.01% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sliedig sliedig merged commit 135050e into aws-powertools:develop Feb 14, 2023
@amirkaws amirkaws deleted the amirkaws-metrics-timestamp-fix branch February 24, 2023 14:55
@amirkaws amirkaws restored the amirkaws-metrics-timestamp-fix branch February 24, 2023 14:55
@amirkaws amirkaws deleted the amirkaws-metrics-timestamp-fix branch February 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants