Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dotnet sdk to 6.0.405 #195

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 7, 2023

Issue number: #203

Summary

update dotnet sdk to 6.0.405

Changes

.NET 6.0.13 (6.0.405 sdk) release carries security fixes.
Official release https://github.com/dotnet/core/blob/main/release-notes/6.0/6.0.13/6.0.13.md?WT.mc_id=dotnet-35129-website

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from sliedig February 7, 2023 15:24
@github-actions github-actions bot added the internal Maintenance changes label Feb 7, 2023
@hjgraca
Copy link
Contributor Author

hjgraca commented Feb 7, 2023

Getting CodeCov 404 error. From what I could find online codecov/codecov-action#598, I think we might need to generate a new token...

@sliedig
Copy link
Contributor

sliedig commented Feb 8, 2023

Getting CodeCov 404 error. From what I could find online codecov/codecov-action#598, I think we might need to generate a new token...

New token generated

@sliedig
Copy link
Contributor

sliedig commented Feb 8, 2023

@hjgraca
Copy link
Contributor Author

hjgraca commented Feb 8, 2023

Test seems to be failing https://github.com/awslabs/aws-lambda-powertools-dotnet/actions/runs/4116108873/jobs/7123440610#step:6:590

Yeah this one test seems very flaky, it worked twice in a row with the new Moq version but guess not.. I'll have a look

   Mock<ISystemWrapper:78> (v):

      ISystemWrapper.LogLine("{"cold_start":true,"correlation_id":"528746ff-75ec-4124-807f-81961f76e9d8","timestamp":"2023-02-08T12:57:47.9053619Z","level":"Information","service":"0e67ec31-9ca0-4183-b31e-6524bd23dd93","name":"880b0526-6828-4639-ae45-e919ba52b9a7","message":{"name":"Test Object","stream":"XpiVwfRYvy\u002Bapw=="}}")

  Stack Trace:
     at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 330
   at Moq.Mock`1.Verify(Expression`1 expression, Times times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 727
   at Moq.Mock`1.Verify(Expression`1 expression, Func`1 times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 741
   at AWS.Lambda.Powertools.Logging.Tests.PowertoolsLoggerTest.Log_WhenMemoryStream_LogsBase64String() in /home/runner/work/aws-lambda-powertools-dotnet/aws-lambda-powertools-dotnet/libraries/tests/AWS.Lambda.Powertools.Logging.Tests/PowertoolsLoggerTest.cs:line 1170

@hjgraca
Copy link
Contributor Author

hjgraca commented Feb 8, 2023

@amirkaws
Copy link
Contributor

I rerun the build, was successful.

@sliedig sliedig merged commit fae639d into aws-powertools:develop Feb 14, 2023
@sliedig sliedig added the pending-release Fix or implementation already in dev waiting to be released label Feb 14, 2023
@hjgraca hjgraca linked an issue Feb 17, 2023 that may be closed by this pull request
2 tasks
@hjgraca hjgraca deleted the update-dotnet-sdk-6.0.405 branch April 12, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes pending-release Fix or implementation already in dev waiting to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Update .NET sdk to 6.0.405
3 participants