Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: docs review #113

Merged
merged 1 commit into from
Mar 16, 2022
Merged

docs: docs review #113

merged 1 commit into from
Mar 16, 2022

Conversation

amirkaws
Copy link
Contributor

@amirkaws amirkaws commented Mar 15, 2022 •
edited
Loading

Issue #, if available:

Description of changes:

This PR fixes some minor issues in documentation

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 15, 2022
@amirkaws amirkaws requested a review from sliedig March 15, 2022 15:10
sliedig
sliedig reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@sliedig sliedig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make a decision on whether to use us-english or uk-english :-)

@sliedig sliedig merged commit 7f29680 into develop Mar 16, 2022
@sliedig sliedig deleted the amirkaws/update-doc-1 branch March 16, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliedig sliedig sliedig approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirkaws @sliedig