Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end Test failed due to incorrect trace format #19

Closed
wyTrivail opened this issue Oct 21, 2020 · 5 comments · Fixed by #34
Closed

End to end Test failed due to incorrect trace format #19

wyTrivail opened this issue Oct 21, 2020 · 5 comments · Fixed by #34
Assignees

Comments

@wyTrivail
Copy link
Contributor

while checking the e2e test failure, i found the log in otcollector as below:

aws-ot-collector_1  | Span #0
aws-ot-collector_1  |     Trace ID       : e5ff1f6fc69c69a7dff5df74ebdf79dfaf3b7b87b8edee1f
aws-ot-collector_1  |     Parent ID      :
aws-ot-collector_1  |     ID             : 7b6efc69e75ff34f387dcd7b
aws-ot-collector_1  |     Name           : GET /
aws-ot-collector_1  |     Kind           : SPAN_KIND_SERVER
aws-ot-collector_1  |     Start time     : 2020-10-21 04:27:24.78015232 +0000 UTC
aws-ot-collector_1  |     End time       : 2020-10-21 04:27:26.786455808 +0000 UTC
aws-ot-collector_1  |     Status code    : STATUS_CODE_OK
aws-ot-collector_1  |     Status message :

the trace id is not a valid xray trace id.

However, the sample app returned trace id as

➜  ~ curl http://127.0.0.1:4567/
{"traceId":"1-5f8fb8ac-aaff9d9069953687e4e47e4f"}%

I'm not sure which part is having issue at this moment, but looks like jssdk sends a wrong trace id?

@KKelvinLo KKelvinLo self-assigned this Oct 28, 2020
@KKelvinLo
Copy link
Contributor

There is a fix currently being implemented described in this issue of the upstream repo.

@wyTrivail
Copy link
Contributor Author

looks like the code is merged, can we check if it can fix this issue?

@KKelvinLo
Copy link
Contributor

There's a dependency issue waiting on the upstream release of this PR#1627 before the traces are exported correctly.

@awssandra
Copy link
Contributor

What's the status here? The PR referenced looks like it's merged.

@KKelvinLo
Copy link
Contributor

KKelvinLo commented Nov 23, 2020

@awssandra I've symlinked the dependencies locally for exporter-collector-grpc and everything works as expected. However, our tests are blocked and cannot call the new dependency until upstream has a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants