Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Update Is Broken #66

Closed
sgtoj opened this issue Oct 31, 2019 · 6 comments
Closed

Latest Update Is Broken #66

sgtoj opened this issue Oct 31, 2019 · 6 comments

Comments

@sgtoj
Copy link

sgtoj commented Oct 31, 2019

Latest Update (10/31/2019, 9:01:32 AM) now show 10s, if not 100s, of linter errors.

Version: 1.40.0-insider (user setup)
Commit: 93ee2fc3121b7f66ddf568c051f3bfff7db8d618
Date: 2019-10-31T05:42:33.138Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.19008
@sgtoj
Copy link
Author

sgtoj commented Oct 31, 2019

I have update the cfn-lint pip package and schemas (cfn-lint -u) then reloaded VS Code. Still an issue.

@kddejong
Copy link
Contributor

kddejong commented Oct 31, 2019

Looking at it. I believe its related to the YAML Schema. "yaml.validate": false in your settings will, I believe, fix it.

Going to work on a way to set that so it isn't enabled by default.

@kddejong
Copy link
Contributor

@sgtoj just published a patch can you install this new version and see if that helps.

@sgtoj
Copy link
Author

sgtoj commented Oct 31, 2019

The patch and/or setting did resolve the issues. I will close this issue. I may provide additional feedback through another github issue.

@sgtoj sgtoj closed this as completed Oct 31, 2019
@kddejong
Copy link
Contributor

That's fair. Thanks for reporting the issue @sgtoj and let me know if you have any more concerns.

@sgtoj
Copy link
Author

sgtoj commented Oct 31, 2019

I never said thank you....

Thank you for your quick response and resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants