Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node build-ins. #9350

Closed
ivands opened this issue Dec 12, 2021 · 2 comments
Closed

Remove node build-ins. #9350

ivands opened this issue Dec 12, 2021 · 2 comments
Assignees
Labels
Build Related to build issues feature-request Request a new feature node.js Related to Node.js pending-v3 Issues pending upgrade of the AWS SDK

Comments

@ivands
Copy link

ivands commented Dec 12, 2021

Is this related to a new or existing framework?

New framework

Is this related to a new or existing API?

Authentication

Describe the feature you'd like to request

Trying to use amplify is a pain right now because for some reason it uses node build-in libraries while it is supposed to work in the browser.
The next generation of build tools (like vite) don't include node's build-in libraries anymore.
Amplify should stop using them and migrate.

Describe the solution you'd like

Stop using node build-in libraries

@ivands ivands added the feature-request Request a new feature label Dec 12, 2021
@jiahao-c
Copy link

jiahao-c commented Jan 4, 2022

This problem has to be fixed by aws-sdk, not Amplify. See aws/aws-sdk-js#3673

@chrisbonifacio chrisbonifacio added Build Related to build issues node.js Related to Node.js labels Mar 31, 2022
@stocaaro stocaaro added the pending-v3 Issues pending upgrade of the AWS SDK label Dec 13, 2022
@cwomack
Copy link
Member

cwomack commented Mar 26, 2024

With the release of the latest major version of Amplify (aws-amplify@>6) and in the latest version of v5 (v5.3.18+), this issue should now be resolved! Please refer to our release announcement, migration guide, and documentation for more information on the v6 release.

Feel free to reply back if this isn't the case or we missed something!

@cwomack cwomack closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to build issues feature-request Request a new feature node.js Related to Node.js pending-v3 Issues pending upgrade of the AWS SDK
Projects
None yet
Development

No branches or pull requests

6 participants