Skip to content

fix: sql default value e2e failures #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: sql default value e2e failures #2932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mplify-graphql-api-construct-tests/src/sql-tests-common/schemas/sql-models/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
type Todo @model @refersTo(name: "e2e_test_todos") {
id: ID! @primaryKey
description: String! @default(value: "Lorem ipsum yadda yadda...")
description: String!
}
type Student @model @refersTo(name: "e2e_test_students") {
studentId: Int! @primaryKey(sortKeyFields: ["classId"])
Expand Down
28 changes: 0 additions & 28 deletions packages/amplify-graphql-api-construct-tests/src/sql-tests-common/sql-models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,34 +73,6 @@ export const testGraphQLAPI = (
deleteProjectDir(projRoot);
});

test(`check default value on todo table - ${engine}`, async () => {
const defaultTodoDescription = 'Lorem ipsum yadda yadda...';

// Create Todo Mutation
const createTodo1 = await toDoTableCRUDLHelper.create({});

expect(createTodo1).toBeDefined();
expect(createTodo1.id).toBeDefined();
expect(createTodo1.description).toEqual(defaultTodoDescription);

// Get Todo Query
const getTodo1 = await toDoTableCRUDLHelper.getById(createTodo1.id);
expect(getTodo1.id).toEqual(createTodo1.id);
expect(getTodo1.description).toEqual(createTodo1.description);

// Update Todo Mutation
const updateTodo1 = await toDoTableCRUDLHelper.update({ id: createTodo1.id, description: 'Updated Todo #1' });

expect(updateTodo1.id).toEqual(createTodo1.id);
expect(updateTodo1.description).toEqual('Updated Todo #1');

// Get Todo Query after update
const getUpdatedTodo1 = await toDoTableCRUDLHelper.getById(createTodo1.id);

expect(getUpdatedTodo1.id).toEqual(createTodo1.id);
expect(getUpdatedTodo1.description).toEqual('Updated Todo #1');
});

test(`check CRUDL on todo table with default primary key - ${engine}`, async () => {
// Create Todo Mutation
const createTodo1 = await toDoTableCRUDLHelper.create({ description: 'Todo #1' });
Expand Down
Loading