Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region is getting masked #368

Closed
vesubramanian opened this issue Jan 25, 2022 · 9 comments
Closed

Region is getting masked #368

vesubramanian opened this issue Jan 25, 2022 · 9 comments
Labels
bug Something isn't working needs-reproduction This issue needs reproduction.

Comments

@vesubramanian
Copy link

On using this action, the region is also getting masked.

@yaldram
Copy link

yaldram commented Sep 5, 2022

Got my solution if we don't want your aws region to get masked please don't use it as a secret like {{secrets.AWS_REGION}} simply hard code it in our workflow commands.

@yaldram
Copy link

yaldram commented Sep 5, 2022

  • name: Configure AWS Credentials
    uses: aws-actions/configure-aws-credentials@v1
    with:
    aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
    aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
    aws-region: ap-south-1

@vesubramanian
Copy link
Author

I am not using it as a secret. But instead of hard coding it, I use a variable. But still it is masked.

@peterwoodworth peterwoodworth added the needs-triage This issue still needs to be triaged label Oct 4, 2022
@peterwoodworth
Copy link
Contributor

This action doesn't set the region as a secret in code like it does with the keys. Can you please share reproduction steps i.e. your workflow file @vesubramanian?

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. bug Something isn't working and removed needs-triage This issue still needs to be triaged labels Oct 11, 2022
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 2 days unless further comments are made. label Oct 17, 2022
@vesubramanian
Copy link
Author

PFB. I am not at all using region as a secret, but reading from the matrix. But still it is masked in the output. You can try this. When I reached out to the support, they were also able to reproduce this and they said, they have communicated this to the engineering team, who were also able to reproduce this. But they haven't given an ETA for the fix.

- name: Configure AWS Credentials for Target Account uses: aws-actions/configure-aws-credentials@v1 with: aws-access-key-id: ${{ secrets[env.ACCESS_KEY_ID_VAR] }} aws-secret-access-key: ${{ secrets[env.ACCESS_KEY_VAR] }} aws-region: ${{ matrix.region }} mask-aws-account-id: 'false'

@github-actions github-actions bot removed closing-soon This issue will automatically close in 2 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. labels Oct 17, 2022
@peterwoodworth peterwoodworth added the needs-reproduction This issue needs reproduction. label Nov 1, 2022
@peterwoodworth
Copy link
Contributor

I wasn't able to reproduce this @vesubramanian,

When I reached out to the support, they were also able to reproduce this and they said, they have communicated this to the engineering team, who were also able to reproduce this

This is interesting to me, I'm not sure which team they reached out to. Do you have any sort of reference to this support issue so I can try to look it up?

@peterwoodworth
Copy link
Contributor

Please feel free to ping me if this issue persists and you have more info on how I can reproduce it. Thanks

@peterwoodworth peterwoodworth closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
@github-actions
Copy link

⚠️Comment Visibility Warning⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-reproduction This issue needs reproduction.
Projects
None yet
Development

No branches or pull requests

3 participants