Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need option to use system libs for build #524

Closed
Vascom opened this issue Feb 28, 2023 · 3 comments · Fixed by #541
Closed

Need option to use system libs for build #524

Vascom opened this issue Feb 28, 2023 · 3 comments · Fixed by #541

Comments

@Vascom
Copy link

Vascom commented Feb 28, 2023

Feature request

Please add options for cmake to build HyperHDR with system libs like flatbuffers, mbedtls and qmqtt.
Fedora rules requred unbundle as much as possible.

What problem does this feature solve?

Build HyperHDR for Fedora and add to official repo.

How should this be implemented in your opinion?

Change CMakeLists.txt file.

Are you willing to work on this yourself?

No. I don't know cmake build system.

@awawa-dev
Copy link
Owner

awawa-dev commented Feb 28, 2023

Hi
flatbuffers and mbedtls are critical core libraries for HyperHDR, each version must be tested before upgrading and I don't see possibility to rely on system libs here. For example current mbedtls 3.3 causing problems for webos. qmqtt also needed some modification to build configuration to make it work also with Qt6 (its CMakeLists.txt is hardlinked to Qt5) but qmqtt is not a critical component and can be disabled with cmake configuration option.

@Vascom
Copy link
Author

Vascom commented Feb 28, 2023

Thanks for clarification.

@awawa-dev
Copy link
Owner

This PR should bring support for Fedora: #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants