Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a release? #57

Closed
utkarsh2102 opened this issue Apr 4, 2020 · 12 comments
Closed

Time for a release? #57

utkarsh2102 opened this issue Apr 4, 2020 · 12 comments

Comments

@utkarsh2102
Copy link

Hi,

There have been 27 commits since the last release, perhaps time for another release? :)

@awalterschulze
Copy link
Owner

version 2.0.1 has been released

Thank you for reporting :)

@awalterschulze
Copy link
Owner

version 2.0.1 is broken

@awalterschulze
Copy link
Owner

Although I can't reproduce the failure locally :(

@utkarsh2102
Copy link
Author

@awalterschulze, eeks, no worries.
I can help you with that bit ;)

@awalterschulze
Copy link
Owner

That would be great.
Also probably should move over to github actions
#58
Might be an easier fix

@awalterschulze
Copy link
Owner

Got the same error on master
https://travis-ci.org/github/awalterschulze/gographviz/builds/671231771?utm_medium=notification&utm_source=email

But locally I don't get this and I have upgraded to go version 14

@utkarsh2102
Copy link
Author

Hi @awalterschulze,
I am using Golang 1.14 and I can't seem to reproduce any failure either.
I built this module in a clean chroot (clean environment) and this seemed to build fine with all tests passing.

@awalterschulze
Copy link
Owner

Awesome, thank you for confirming :)
Then I think this issue now depends on switching to github actions: #58

@utkarsh2102
Copy link
Author

Right, so if you need help in reproducing or something, I'll be a ping away ;)
I'd have helped with #58, definitely, but I've got zero experience in that :/

Furthermore, I also built aptly against 2.0.1 version and things seemed fine. So I don't think it is much of a problem :)

@awalterschulze
Copy link
Owner

Cool, great to hear.

I'll wait for someone with XP or anyone willing to learn.

I am also a bit busy right now.

@awalterschulze
Copy link
Owner

github action has been implemented thanks to @jmrtt
So I made another release version 2.0.2

I think maybe now we can close this issue, since it is easy to make new releases in future.
Feel free to still comment on this issue.

@utkarsh2102
Copy link
Author

This is great, thanks @awalterschulze and @jmrtt! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants