Skip to content

Commit cf01b11

Browse files
committed
- fix: primefaces#6116 prevent dialog from closing when releasing mouse outside the dialog and dismissableMask is set to true
1 parent 81f55da commit cf01b11

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/primevue/src/dialog/Dialog.vue

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<Portal :appendTo="appendTo">
3-
<div v-if="containerVisible" :ref="maskRef" :class="cx('mask')" :style="sx('mask', true, { position, modal })" @click="onMaskClick" v-bind="ptm('mask')">
3+
<div v-if="containerVisible" :ref="maskRef" :class="cx('mask')" :style="sx('mask', true, { position, modal })" @mousedown="onMaskMouseDown" @mouseup="onMaskMouseUp" v-bind="ptm('mask')">
44
<transition name="p-dialog" @before-enter="onBeforeEnter" @enter="onEnter" @before-leave="onBeforeLeave" @leave="onLeave" @after-leave="onAfterLeave" appear v-bind="ptm('transition')">
55
<div v-if="visible" :ref="containerRef" v-focustrap="{ disabled: !modal }" :class="cx('root')" :style="sx('root')" role="dialog" :aria-labelledby="ariaLabelledById" :aria-modal="modal" v-bind="ptmi('root')">
66
<slot v-if="$slots.container" name="container" :closeCallback="close" :maximizeCallback="(event) => maximize(event)"></slot>
@@ -113,6 +113,7 @@ export default {
113113
documentDragEndListener: null,
114114
lastPageX: null,
115115
lastPageY: null,
116+
maskMouseDownTarget: null,
116117
updated() {
117118
if (this.visible) {
118119
this.containerVisible = this.visible;
@@ -174,8 +175,11 @@ export default {
174175
this.unbindGlobalListeners();
175176
this.$emit('after-hide');
176177
},
177-
onMaskClick(event) {
178-
if (this.dismissableMask && this.modal && this.mask === event.target) {
178+
onMaskMouseDown(event) {
179+
this.maskMouseDownTarget = event.target;
180+
},
181+
onMaskMouseUp() {
182+
if (this.dismissableMask && this.modal && this.mask === this.maskMouseDownTarget) {
179183
this.close();
180184
}
181185
},

0 commit comments

Comments
 (0)