Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing selected item when navigating to record #3500

Open
2 of 4 tasks
johnvtroy opened this issue Dec 9, 2024 · 3 comments
Open
2 of 4 tasks

Losing selected item when navigating to record #3500

johnvtroy opened this issue Dec 9, 2024 · 3 comments
Labels
😎 Cool Help wanted We could use some help with this Stale exempt

Comments

@johnvtroy
Copy link

johnvtroy commented Dec 9, 2024

Context

When you select a record and then navigate to a record and then use the go back button you lose the check mark on the selected item. Also, if you had scrolled to the bottom of a long list it also sends you back to the top of the page after you go back. Is there any way that this context could be saved when navigating to a record?

System configuration

Avo version: 3.15.0

Rails version: 7.2.0

Ruby version: 3.3.1

License type

  • Community
  • Pro

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

09.12.2024_11.49.56_REC.mp4
@johnvtroy johnvtroy changed the title Lose selected item when navigating to record Losing selected item when navigating to record Dec 9, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@johnvtroy
Copy link
Author

can this be reopened?

@adrianthedev
Copy link
Collaborator

Hey @johnvtroy.
Yes, we can reopen it.

This is a more advanced feature where we need to store the selection somewhere. My guess is that we need to store it in localstorage and reselect the items when the page is loaded.
Another place could be in session but that's not the usecase that I think our users need.

That being said, this requires a bit more attention which we don't yet have right now.

So there are two ways of dealing with this:

  1. You can submit a PR and we can put it thorugh the approval process
  2. If this is something critical for your experience, we can set up a call and figure out a way for you to sponsor this feature and we can find some time to work on it.

Either way, thanks for sending in this PR. It's a great feature to have.

@adrianthedev adrianthedev added Help wanted We could use some help with this 😎 Cool labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 Cool Help wanted We could use some help with this Stale exempt
Projects
Status: No status
Development

No branches or pull requests

2 participants