-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secondary labels above each field #2604
Comments
I'm not able to reproduce it, can you please provide a minimal reproduction repository? It only need to include an app with avo installed and 1 resource where this is happening |
I will try, but I'm afraid I will not be able to… If you have any idea where to start digging in our app I'll try. |
I would start by inspecting the element and try to figure out where is it rendered in the component |
Closing this as we can't reproduce it. |
@adrianthedev Sure, thanks, I will try to investigate this as soon as I have a while and get back. |
I found it. It was caused by Foundation Rails Helper used in our legacy app, which adds labels to all form fields. The fix was to disable it in FoundationRailsHelper.configure do |config|
config.auto_labels = false
end So not an issue related to Avo (or – just to the fact that it is Rails engine). |
Wow. What a wild find! |
Describe the bug
Discussed in #2578
I have duplicate labels above each input in edit view. When there is a translation for such field:
it is even translated:
Expected behavior & Actual behavior
There are no secondary labels.
Models and resource files
System configuration
Avo version: 3.5.3
Rails version: 6.1.7.7
Ruby version: 3.1.4
License type:
Are you using Avo monkey patches, overriding views or view components?
Screenshots or screen recordings
Additional context
view_component version is 3.11.0
Impact
Urgency
The text was updated successfully, but these errors were encountered: