Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the user has declared the plugin and dependency #31

Open
fasfsfgs opened this issue Jun 14, 2017 · 2 comments
Open

Check if the user has declared the plugin and dependency #31

fasfsfgs opened this issue Jun 14, 2017 · 2 comments

Comments

@fasfsfgs
Copy link
Contributor

fasfsfgs commented Jun 14, 2017

As written on README.md from earlier versions, for this extension to function properly when using Connect to a running nREPL it's necessary for the user to add cider-nrepl plugin and tools.nrepl dependency.

If they don't do it, there are no clear warnings about it and the extension just doesn't work as intended (as seen on #30 comments).

The idea here is to check if those dependencies are correctly declared and warn the user otherwise.

@fasfsfgs
Copy link
Contributor Author

I think a good start is to check for those dependencies when trying to connect to the repl. If we find out that the configuration is not done correctly, we warn the user and don't connect to the repl.

Agree @avli?

@avli
Copy link
Owner

avli commented Jul 9, 2017

This one will be automatically solved after #21 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants