Show report generated time when date range includes today (matomo-org#17506)

* wip

* wip

* report generated tooltip

* show only if date includes today

* show generated date for evo graphs

* add and use new clock icon

* force html formatter

* delete metadata from api response for multisite API

* redo show report generated for evo graph

* fix ui tests

* Update Archive.php

Author: Zoltan Flamis

LEGALNOTICE

@@ -217,7 +217,7 @@ THIRD-PARTY COMPONENTS AND LIBRARIES
 	Link: http://raphaeljs.com/
 	License: MIT (Expat)
 
-	Name: iFrame Resizer 
+	Name: iFrame Resizer
 	Link: https://github.com/davidjbradshaw/iframe-resizer
 	License: MIT
 
@@ -279,7 +279,7 @@ THIRD-PARTY CONTENT
 	License: GPL
 	By: Alessandro Rei - http://www.kde-look.org/usermanager/search.php?username=mentalrey
 
-	Name: Material icons ("icon-info2", "icon-outline", "icon-settings", "icon-form", "icon-play", "icon-pause", "icon-replay", "icon-skip-next", "icon-skip-forward", "icon-stop", "icon-fast-forward", "icon-fast-rewind", "icon-bug", "icon-upload", "icon-segmented-visits-log") in plugins/Morpheus/fonts, and plugins/Morpheus/images/compare.svg
+	Name: Material icons ("icon-info2", "icon-outline", "icon-settings", "icon-form", "icon-play", "icon-pause", "icon-replay", "icon-skip-next", "icon-skip-forward", "icon-stop", "icon-fast-forward", "icon-fast-rewind", "icon-bug", "icon-upload", "icon-segmented-visits-log", "icon-clock") in plugins/Morpheus/fonts, and plugins/Morpheus/images/compare.svg
 	Link: https://design.google.com/icons/
 	License: Apache License Version 2.0
 
@@ -294,6 +294,6 @@ THIRD-PARTY CONTENT
 Notes:
 - the "New BSD" license refers to either the "Modified BSD" and "Simplified BSD"
   licenses (2- or 3-clause), which are GPL compatible.
-- icons for browsers, operating systems, browser plugins, brands, search engines, social media websites 
+- icons for browsers, operating systems, browser plugins, brands, search engines, social media websites
   and flags of countries are nominative use of third-party trademarks when
   referring to the corresponding product or entity

core/ArchiveProcessor.php

@@ -582,7 +582,7 @@ public function renameColumnsAfterAggregation(DataTable $table, $columnsToRename
         if (empty($columnsToRenameAfterAggregation)) {
             return;
         }
-        
+
         foreach ($table->getRows() as $row) {
             foreach ($columnsToRenameAfterAggregation as $oldName => $newName) {
                 $row->renameColumn($oldName, $newName);

plugins/CoreHome/angularjs/enrichedheadline/enrichedheadline.directive.html

@@ -23,6 +23,8 @@
              title="{{ featureName }}"></div>
     </span>
 
+    <div ng-show="showReportGenerated" class="icon-clock report-generated"></div>
+
     <div class="inlineHelp" ng-show="view.showInlineHelp">
         <div ng-bind-html="inlineHelp"></div>
         <a ng-if="helpUrl"

plugins/CoreHome/angularjs/enrichedheadline/enrichedheadline.directive.js

@@ -28,16 +28,22 @@
  * </h2>
  * -> alternative definition for inline help
  * -> shows help icon to display inline help on click. Note: You can combine inlinehelp and help-url
+ *
+ * * <h2 piwik-enriched-headline report-generated="generated time">Pages report</h2>
+ * -> reportGenerated specified via this attribute shows a clock icon with a tooltip which activated by hover
+ * -> the tooltip shows the value of the attribute
  */
 (function () {
     angular.module('piwikApp').directive('piwikEnrichedHeadline', piwikEnrichedHeadline);
 
-    piwikEnrichedHeadline.$inject = ['$document', 'piwik', '$filter', '$parse'];
+    piwikEnrichedHeadline.$inject = ['$document', 'piwik', '$filter', '$parse', 'piwikPeriods'];
 
-    function piwikEnrichedHeadline($document, piwik, $filter, $parse){
+    function piwikEnrichedHeadline($document, piwik, $filter, $parse, piwikPeriods){
         var defaults = {
             helpUrl: '',
-            editUrl: ''
+            editUrl: '',
+            reportGenerated: '',
+            showReportGenerated: '',
         };
 
         return {
@@ -46,8 +52,10 @@
             scope: {
                 helpUrl: '@',
                 editUrl: '@',
+                reportGenerated: '@?',
                 featureName: '@',
-                inlineHelp: '@?'
+                inlineHelp: '@?',
+                showReportGenerated: '=?'
             },
             templateUrl: 'plugins/CoreHome/angularjs/enrichedheadline/enrichedheadline.directive.html?cb=' + piwik.cacheBuster,
             compile: function (element, attrs) {
@@ -87,8 +95,20 @@
                     if (!attrs.featureName) {
                         attrs.featureName = $.trim(element.find('.title').first().text());
                     }
+
+                    if (scope.reportGenerated && piwikPeriods.parse(piwik.period, piwik.currentDateString).containsToday()) {
+                        element.find('.report-generated').first().tooltip({
+                            track: true,
+                            content: scope.reportGenerated,
+                            items: 'div',
+                            show: false,
+                            hide: false
+                        });
+
+                        scope.showReportGenerated = '1';
+                    }
                 };
             }
         };
     }
-})();
+})();

plugins/CoreHome/angularjs/enrichedheadline/enrichedheadline.directive.less

@@ -62,4 +62,13 @@
             text-decoration: none;
         }
     }
+
+    .report-generated {
+        float: right;
+        cursor: pointer;
+        font-size: 14px;
+        color:#888;
+        opacity: 0.3;
+        line-height: 32px;
+    }
 }

plugins/CoreHome/templates/_dataTable.twig

@@ -13,6 +13,7 @@
     {% if properties.title %}
         <h2 class="card-title"
             {% if properties.title_edit_entity_url %}edit-url="{{ properties.title_edit_entity_url }}"{% endif %}
+            {% if reportLastUpdatedMessage is defined and reportLastUpdatedMessage %}report-generated="{{ reportLastUpdatedMessage|raw }}"{% endif %}
               piwik-enriched-headline
         >{{ properties.title }}</h2>
     {% endif %}

plugins/Morpheus/fonts/matomo.svg

@@ -387,4 +387,7 @@
 }
 .icon-page-performance:before {
   content: "\e9a6";
-}
+}
+.icon-clock:before {
+  content: "\e901";
+}

plugins/Morpheus/fonts/matomo.ttf

@@ -667,7 +667,8 @@
                         'form',
                         'transition',
                         'overlay',
-                        'lab'
+                        'lab',
+                        'clock'
                     ],
                     'Users': [
                         'user',

plugins/Morpheus/fonts/matomo.woff

@@ -148,4 +148,4 @@ public static function getOutputPrefix()
 }
 
 TwoVisitorsTwoWebsitesDifferentDaysConversionsTest::$fixture = new TwoSitesTwoVisitorsDifferentDays();
-TwoVisitorsTwoWebsitesDifferentDaysConversionsTest::$fixture->allowConversions = true;
+TwoVisitorsTwoWebsitesDifferentDaysConversionsTest::$fixture->allowConversions = true;