Fix possible memory leak in MachOFormat::symtabCommand() method. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symtabCommand method was exited without releasing the 'symbolTable' pointer.
s3rvac
approved these changes
Jun 10, 2018
|
Nice catch, thanks! |
Maroc-OS
added a commit
to Maroc-OS/retdec
that referenced
this pull request
Jul 3, 2018
Maroc-OS
added a commit
to Maroc-OS/retdec
that referenced
this pull request
Jul 3, 2018
FIX: avast#331 Unify build visibility for all projects
Maroc-OS
added a commit
to Maroc-OS/retdec
that referenced
this pull request
Jul 3, 2018
PeterMatula
pushed a commit
that referenced
this pull request
Jul 10, 2018
* Fix compiler warning (unused variable 'ai') * Eliminate "lib*.a(filexx.cpp.o)" has no symbols on macOS On macOS there is some warnings about object that has no symbols in it, this is needed to be fixed to make building more clean and clear. example of build log : ``` [ 94%] Linking CXX static library libretdec-bin2llvmir.a /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libretdec-bin2llvmir.a(idioms_borland.cpp.o) has no symbols ``` * FIX: #331 Unify build visibility for all projects Unify build visibility for all projects to avoid warnings "direct access in function: * from file: * to global weak symbol". PS: used same function 'append_if' from LLVM Project CMakeLists.txt file This will fix #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symtabCommand method was exited without releasing the 'symbolTable' pointer.