-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] Added endpoint to get all reports of student in JSON #20
Conversation
generate_table/__main__.py
Outdated
|
||
|
||
def drop_secondary_ind(): | ||
drop_secondary_index("gsi_user_id-section") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be "gsi_user_Id"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these methods are meant to be run manually, mostly one-time. Will actually make this a parameter for the function.
generate_table/__main__.py
Outdated
@@ -35,5 +40,15 @@ def drop_tables(): | |||
drop_student_quiz_reports(ddb) | |||
|
|||
|
|||
def add_secondary_ind(): | |||
# DON'T RUN THIS for the key user_id key as it's already been run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this is getting run by default in `if name == "main" ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment explaining things
generate_table/__main__.py
Outdated
""" | ||
Drops a secondary index | ||
""" | ||
drop_secondary_index(index_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop_secondary_index(ddb, index_name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and ddb = initialize_db()
Sample output: