-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding_quiz_link #11
Adding_quiz_link #11
Conversation
QUIZ_URL = ( | ||
"https://quiz.avantifellows.org/quiz/{quiz_id}?userId={user_id}&apiKey={api_key}" | ||
) | ||
AF_API_KEY = "6qOO8UdF1EGxLgzwIbQN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to leave this hardcoded? Better to use as env variable, no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's okay. It's in all our quiz URLs, no point hiding it :P
Merging from main to quiz link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Also deleted some unused routes