V0 #1
Merged
V0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 27, 2022 11:01
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
app/routers/student_quiz_reports.py
Outdated
| def create_student_quiz_report(report_data: CreateStudentQuizReportModel): | ||
| return self.__student_quiz_reports_controller.create_student_quiz_report(report_data) | ||
|
|
||
| @api_router.get('/get/{student_quiz_report_uid}') |
There was a problem hiding this comment.
student_quiz_report_uid not used
There was a problem hiding this comment.
Oh was playing with the URL params. Will update this, thanks!
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
suryabulusu
reviewed
Aug 3, 2022
added 2 commits
August 4, 2022 07:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V0 of the reporting engine. Includes:
student_quiz_reportstableStack is FastAPI + DynamoDB
I have kept all interactions with the DB in a separate layer so that if we switch away from DynamoDB life will be simple.
The APIs are made to be used by the reports. FastAPI will be our default frontend, but we can build others with the API