remove TODO comments

Author: Darioush Jalali

core/blockchain.go

@@ -935,7 +935,7 @@ func (bc *BlockChain) stopWithoutSaving() {
 	}
 
 	log.Info("Closing quit channel")
-	close(bc.quit) // XXX: Why is this closed before [scope] but it's opposite upstream?
+	close(bc.quit)
 	// Wait for accepted feed to process all remaining items
 	log.Info("Stopping Acceptor")
 	start := time.Now()

core/txindexer.go

@@ -65,7 +65,7 @@ func newTxIndexer(limit uint64, chain *BlockChain) *txIndexer {
 	}
 	chain.wg.Add(1)
 	var (
-		headCh = make(chan ChainEvent, 1) // XXX: Buffered to avoid locking up the event feed
+		headCh = make(chan ChainEvent, 1)
 		sub    = chain.SubscribeChainAcceptedEvent(headCh)
 	)
 	go func() {

core/txindexer_test.go

@@ -31,7 +31,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-// XXX: These tests are moved from blockchain_test.go here.
 // Should we try to use the TestTxIndexer from upstream here instead
 // or move this test to a new file eg, blockchain_extra_test.go?
 func TestTransactionIndices(t *testing.T) {

ethclient/simulated/backend.go

@@ -97,7 +97,6 @@ func NewBackend(alloc types.GenesisAlloc, options ...func(nodeConf *node.Config,
 	ethConf.AllowUnfinalizedQueries = true
 	ethConf.Miner.Etherbase = constants.BlackholeAddr
 	ethConf.Miner.AllowDuplicateBlocks = true
-	ethConf.GPO.MinPrice = new(big.Int).SetUint64(ethConf.TxPool.PriceLimit) // XXX: this constraint should be enforced
 	ethConf.TxPool.NoLocals = true
 
 	for _, option := range options {

params/config.go

@@ -56,7 +56,7 @@ var (
 		ConstantinopleBlock: big.NewInt(0),
 		PetersburgBlock:     big.NewInt(0),
 		IstanbulBlock:       big.NewInt(0),
-		MuirGlacierBlock:    big.NewInt(0),                                  // XXX: Should this include Cancun time?
+		MuirGlacierBlock:    big.NewInt(0),
 		NetworkUpgrades:     getDefaultNetworkUpgrades(constants.MainnetID), // This can be changed to correct network (local, test) via VM.
 		GenesisPrecompiles:  Precompiles{},
 	}
@@ -236,7 +236,7 @@ func (c *ChainConfig) Description() string {
 	}
 
 	banner += "Hard forks (timestamp based):\n"
-	banner += fmt.Sprintf(" - Cancun Timestamp:              @%-10v (https://github.com/ava-labs/avalanchego/releases/tag/v1.12.0)\n", ptrToString(c.CancunTime)) /// XXX: should we link the ethereum execution spec here instead
+	banner += fmt.Sprintf(" - Cancun Timestamp:              @%-10v (https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md)\n", ptrToString(c.CancunTime))
 	banner += fmt.Sprintf(" - Verkle Timestamp:              @%-10v", ptrToString(c.VerkleTime))
 
 	banner += "Avalanche Upgrades (timestamp based):\n"

precompile/contracts/nativeminter/contract.go

@@ -118,7 +118,7 @@ func mintNativeCoin(accessibleState contract.AccessibleState, caller common.Addr
 		stateDB.CreateAccount(to)
 	}
 
-	amountU256, _ := uint256.FromBig(amount) // XXX: should we check overflow?
+	amountU256, _ := uint256.FromBig(amount)
 	stateDB.AddBalance(to, amountU256)
 	// Return an empty output and the remaining gas
 	return []byte{}, remainingGas, nil

precompile/contracts/nativeminter/module.go

@@ -54,7 +54,7 @@ func (*configurator) Configure(chainConfig precompileconfig.ChainConfig, cfg pre
 	for to, amount := range config.InitialMint {
 		if amount != nil {
 			amountBig := (*big.Int)(amount)
-			amountU256, _ := uint256.FromBig(amountBig) // XXX: should we check overflow?
+			amountU256, _ := uint256.FromBig(amountBig)
 			state.AddBalance(to, amountU256)
 		}
 	}

stateupgrade/state_upgrade.go

@@ -30,7 +30,7 @@ func upgradeAccount(account common.Address, upgrade params.StateUpgradeAccount,
 	}
 
 	if upgrade.BalanceChange != nil {
-		balanceChange, _ := uint256.FromBig((*big.Int)(upgrade.BalanceChange)) // XXX: do we need to check overflow?
+		balanceChange, _ := uint256.FromBig((*big.Int)(upgrade.BalanceChange))
 		state.AddBalance(account, balanceChange)
 	}
 	if len(upgrade.Code) != 0 {