Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of testing in production binary #3174

Open
ARR4N opened this issue Jul 4, 2024 · 1 comment
Open

Import of testing in production binary #3174

ARR4N opened this issue Jul 4, 2024 · 1 comment
Assignees
Labels
cleanup Code quality improvement lifecycle/stale

Comments

@ARR4N
Copy link
Contributor

ARR4N commented Jul 4, 2024

#3173 introduces a linter to catch leaking of test-only code into production. Most instances of testing imports can be excluded with build tags. This is a tracking issue to document the need for refactoring of the rest.

See: failing CI with removal of final workaround.

Resolution criteria

The workaround was to trick the linter's regex with //go:build test || !test to allow the PR to merge and this refactor to be tackled separately. All instances of said workaround have a TODO with this issue linked, and the issue SHOULD NOT be considered resolve until all are removed.

Copy link

github-actions bot commented Sep 8, 2024

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement lifecycle/stale
Projects
Status: Backlog 🗄️
Development

Successfully merging a pull request may close this issue.

1 participant