Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] add effective proposer slot to the metrics #3051

Closed
tsachiherman opened this issue May 24, 2024 · 0 comments · Fixed by #3048
Closed

[metrics] add effective proposer slot to the metrics #3051

tsachiherman opened this issue May 24, 2024 · 0 comments · Fixed by #3048
Assignees
Labels
enhancement New feature or request

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented May 24, 2024

Context and scope
The goal of this issue is to add a metrics gauge(s) that would enable the tracking of the effective proposer slot.
In order to achieve that, we'll be adding 2 metrics:

  1. A metric showing when my local node is going to attempt to propose the block (either by showing the slot index for the next block or by showing how much time I'm waiting until I'm the block producer or something)
  2. A metric counting the slot indices of accepted blocks

Discussion and alternatives

  1. In order to accomplish the first goal, we'll add a gauge during SetPrefrence. That might be a bit noisy, as it would report both selected and non-selected slots.
  2. Create a slots histogram during the block Accept, allowing us to collect statistics.

Open questions

@tsachiherman tsachiherman added the enhancement New feature or request label May 24, 2024
@tsachiherman tsachiherman self-assigned this May 24, 2024
@tsachiherman tsachiherman linked a pull request May 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant