Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SDK Clients to accept variadic options parameters #2126

Closed
joshua-kim opened this issue Oct 3, 2023 · 2 comments · Fixed by #2283
Closed

Refactor SDK Clients to accept variadic options parameters #2126

joshua-kim opened this issue Oct 3, 2023 · 2 comments · Fixed by #2283
Assignees
@joshua-kim
Labels
enhancement New feature or request lifecycle/stale sdk This involves SDK tooling or frameworks

Comments

@joshua-kim
Copy link
Contributor

Refactor RegisterAppProtocol to accept a variadic parameter of client options to modify the client returned (sampling peers/validators, provide a sampling config, etc).
@joshua-kim joshua-kim added enhancement New feature or request sdk This involves SDK tooling or frameworks labels Oct 3, 2023
@joshua-kim joshua-kim self-assigned this Oct 3, 2023
@github-project-automation github-project-automation bot moved this to Backlog 🗄 in Ski Patrol Oct 3, 2023
@joshua-kim joshua-kim moved this from Backlog 🗄️ to In Progress 🏗 in Platform Engineering Group Nov 15, 2023
@joshua-kim joshua-kim linked a pull request Nov 15, 2023 that will close this issue
Add p2p.Network component #2283
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

@joshua-kim
Copy link
Contributor Author

Closing since we've merged in #2283

@github-project-automation github-project-automation bot moved this from In Progress 🏗 to Done ✅ in Platform Engineering Group Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-kim joshua-kim

Labels
enhancement New feature or request lifecycle/stale sdk This involves SDK tooling or frameworks
Projects
Platform Engineering Group
Archived in project
Ski Patrol
Status: Backlog 🗄
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add p2p.Network component ava-labs/avalanchego
1 participant
@joshua-kim