From f9bade811e3fbba2c38ae246cdde25459269eeac Mon Sep 17 00:00:00 2001 From: Maru Newby Date: Sun, 20 Aug 2023 20:56:23 -0700 Subject: [PATCH] fixup: respond to review feedback #3 --- tests/fixture/testnet/local/node.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/fixture/testnet/local/node.go b/tests/fixture/testnet/local/node.go index 8f5e58f0d39..0333e0ef84e 100644 --- a/tests/fixture/testnet/local/node.go +++ b/tests/fixture/testnet/local/node.go @@ -322,7 +322,11 @@ func (n *LocalNode) IsHealthy(ctx context.Context) (bool, error) { return false, fmt.Errorf("failed to query node health: %w", err) } +// WaitForHealthy blocks until IsHealthy returns true or an error (including context timeout) is observed. func (n *LocalNode) WaitForHealthy(ctx context.Context) error { + if _, ok := ctx.Deadline(); !ok { + return fmt.Errorf("unable to wait for health for node %q with a context without a deadline", n.NodeID) + } ticker := time.NewTicker(DefaultNodeTickerInterval) defer ticker.Stop()