Remove IssueStopVertex message (#1419)

Author: StephenButtolph

snow/engine/common/message.go

@@ -21,9 +21,6 @@ const (
 	// StateSyncDone notifies the state syncer engine that the VM has finishing
 	// syncing the requested state summary.
 	StateSyncDone
-
-	// StopVertex notifies a consensus that it has a pending stop vertex
-	StopVertex
 )
 
 func (msg Message) String() string {
@@ -32,8 +29,6 @@ func (msg Message) String() string {
 		return "Pending Transactions"
 	case StateSyncDone:
 		return "State Sync Done"
-	case StopVertex:
-		return "Pending Stop Vertex"
 	default:
 		return fmt.Sprintf("Unknown Message: %d", msg)
 	}

vms/avm/client.go

@@ -44,8 +44,6 @@ type Client interface {
 	ConfirmTx(ctx context.Context, txID ids.ID, freq time.Duration, options ...rpc.Option) (choices.Status, error)
 	// GetTx returns the byte representation of [txID]
 	GetTx(ctx context.Context, txID ids.ID, options ...rpc.Option) ([]byte, error)
-	// IssueStopVertex issues a stop vertex.
-	IssueStopVertex(ctx context.Context, options ...rpc.Option) error
 	// GetUTXOs returns the byte representation of the UTXOs controlled by [addrs]
 	GetUTXOs(
 		ctx context.Context,
@@ -282,10 +280,6 @@ func (c *client) IssueTx(ctx context.Context, txBytes []byte, options ...rpc.Opt
 	return res.TxID, err
 }
 
-func (c *client) IssueStopVertex(ctx context.Context, options ...rpc.Option) error {
-	return c.requester.SendRequest(ctx, "avm.issueStopVertex", &struct{}{}, &struct{}{}, options...)
-}
-
 func (c *client) GetTxStatus(ctx context.Context, txID ids.ID, options ...rpc.Option) (choices.Status, error) {
 	res := &GetTxStatusReply{}
 	err := c.requester.SendRequest(ctx, "avm.getTxStatus", &api.JSONTxID{

vms/avm/service.go

@@ -201,11 +201,6 @@ func (s *Service) IssueTx(_ *http.Request, args *api.FormattedTx, reply *api.JSO
 	return nil
 }
 
-// TODO: After the chain is linearized, remove this.
-func (s *Service) IssueStopVertex(_ *http.Request, _, _ *struct{}) error {
-	return s.vm.issueStopVertex()
-}
-
 // GetTxStatusReply defines the GetTxStatus replies returned from the API
 type GetTxStatusReply struct {
 	Status choices.Status `json:"status"`

vms/avm/vm.go

@@ -555,16 +555,6 @@ func (vm *VM) IssueTx(b []byte) (ids.ID, error) {
 	return tx.ID(), nil
 }
 
-// TODO: After the chain is linearized, remove this.
-func (vm *VM) issueStopVertex() error {
-	select {
-	case vm.toEngine <- common.StopVertex:
-	default:
-		vm.ctx.Log.Debug("dropping common.StopVertex message to engine due to contention")
-	}
-	return nil
-}
-
 /*
  ******************************************************************************
  ********************************** Timer API *********************************