Merge pull request #684 from ava-labs/proxy-fix

use localhost instead of 0.0.0.0 for proxy fix

Author: felipemadero

cmd/control/control.go

@@ -51,7 +51,7 @@ func NewCommand() *cobra.Command {
 
 	cmd.PersistentFlags().StringVar(&logLevel, "log-level", logging.Info.String(), "log level")
 	cmd.PersistentFlags().StringVar(&logDir, "log-dir", "", "log directory")
-	cmd.PersistentFlags().StringVar(&endpoint, "endpoint", "0.0.0.0:8080", "server endpoint")
+	cmd.PersistentFlags().StringVar(&endpoint, "endpoint", "localhost:8080", "server endpoint")
 	cmd.PersistentFlags().DurationVar(&dialTimeout, "dial-timeout", 10*time.Second, "server dial timeout")
 	cmd.PersistentFlags().DurationVar(&requestTimeout, "request-timeout", 3*time.Minute, "client request timeout")
 

cmd/ping/ping.go

@@ -29,7 +29,7 @@ func NewCommand() *cobra.Command {
 	}
 
 	cmd.PersistentFlags().StringVar(&logLevel, "log-level", logging.Info.String(), "log level")
-	cmd.PersistentFlags().StringVar(&endpoint, "endpoint", "0.0.0.0:8080", "server endpoint")
+	cmd.PersistentFlags().StringVar(&endpoint, "endpoint", "localhost:8080", "server endpoint")
 	cmd.PersistentFlags().DurationVar(&dialTimeout, "dial-timeout", 10*time.Second, "server dial timeout")
 	cmd.PersistentFlags().DurationVar(&requestTimeout, "request-timeout", 10*time.Second, "client request timeout")
 

docs/blockchain-examples.md

@@ -102,7 +102,7 @@ curl -X POST -k http://localhost:8081/v1/control/start -d '{"numNodes":5,"logLev
 # or
 avalanche-network-runner control start \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --blockchain-specs '[{"vm_name": "subnetevm", "genesis": "/tmp/subnet-evm.genesis.json"}]'
 ```
 
@@ -119,7 +119,7 @@ curl -X POST -k http://localhost:8081/v1/control/start -d '{"numNodes":5,"logLev
 # or
 avalanche-network-runner control start \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --blockchain-specs '[{"vm_name": "subnetevm", "genesis": "/tmp/subnet-evm.genesis.json", "chain_config": "'$CHAIN_CONFIG_PATH'", "network_upgrade": "'$NETWORK_UPGRADE_PATH'", "subnet_config": "'$SUBNET_CONFIG_PATH'"}]'
 ```
 
@@ -183,7 +183,7 @@ curl -X POST -k http://localhost:8081/v1/control/start -d '{"numNodes":5,"logLev
 # or
 avalanche-network-runner control start \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --blockchain-specs '[{"vm_name": "blobvm", "genesis": "/tmp/blobvm.genesis.json"}]'
 ```
 
@@ -200,7 +200,7 @@ curl -X POST -k http://localhost:8081/v1/control/start -d '{"numNodes":5,"logLev
 # or
 avalanche-network-runner control start \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --blockchain-specs '[{"vm_name": "blobvm", "genesis": "/tmp/blobvm.genesis.json", "chain_config": "'$CHAIN_CONFIG_PATH'", "network_upgrade": "'$NETWORK_UPGRADE_PATH'", "subnet_config": "'$SUBNET_CONFIG_PATH'"}]'
 ```
 
@@ -264,7 +264,7 @@ curl -X POST -k http://localhost:8081/v1/control/start -d '{"numNodes":5,"logLev
 # or
 avalanche-network-runner control start \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --blockchain-specs '[{"vm_name":"timestampvm","genesis":"/tmp/timestampvm.genesis.json","blockchain_alias":"timestamp"}]'
 ```
 

docs/examples.md

@@ -323,7 +323,7 @@ curl -X POST -k http://localhost:8081/v1/control/removenode -d '{"name":"node5"}
 avalanche-network-runner control remove-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node5
 ```
 
@@ -338,7 +338,7 @@ curl -X POST -k http://localhost:8081/v1/control/restartnode -d '{"name":"node1"
 avalanche-network-runner control restart-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node1 
 ```
 
@@ -353,7 +353,7 @@ curl -X POST -k http://localhost:8081/v1/control/addnode -d '{"name":"node99","l
 avalanche-network-runner control add-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node99 
 ```
 
@@ -368,7 +368,7 @@ curl -X POST -k http://localhost:8081/v1/control/pausenode -d '{"name":"node99",
 avalanche-network-runner control pause-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node99 
 ```
 
@@ -381,7 +381,7 @@ curl -X POST -k http://localhost:8081/v1/control/resumenode -d '{"name":"node99"
 avalanche-network-runner control resume-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node99 
 ```
 
@@ -412,7 +412,7 @@ curl -X POST -k http://localhost:8081/v1/control/attachpeer -d '{"nodeName":"nod
 avalanche-network-runner control attach-peer \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --node-name node1
 ```
 
@@ -425,7 +425,7 @@ curl -X POST -k http://localhost:8081/v1/control/sendoutboundmessage -d '{"nodeN
 avalanche-network-runner control send-outbound-message \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --node-name node1 \
 --peer-id "7Xhw2mDxuDS44j42TCB6U5579esbSt3Lg" \
 --message-op=16 \
@@ -442,7 +442,7 @@ curl -X POST -k http://localhost:8081/v1/control/stop
 # or
 avalanche-network-runner control stop \
 --log-level debug \
---endpoint="0.0.0.0:8080"
+--endpoint="localhost:8080"
 ```
 
 Note: this does not stops the server.

docs/reference.md

@@ -3,7 +3,7 @@
 ## Global Flags
 
 - `--dial-timeout duration`      server dial timeout (default 10s)
-- `--endpoint string`            server endpoint (default "0.0.0.0:8080")
+- `--endpoint string`            server endpoint (default "localhost:8080")
 - `--log-dir string`             log directory
 - `--log-level string`           log level (default "INFO")
 - `--request-timeout duration`   client request timeout (default 3m0s)
@@ -622,7 +622,7 @@ cli
 avalanche-network-runner control restart-node \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 node1 
 ```
 
@@ -741,7 +741,7 @@ cli
 avalanche-network-runner control send-outbound-message \
 --request-timeout=3m \
 --log-level debug \
---endpoint="0.0.0.0:8080" \
+--endpoint="localhost:8080" \
 --node-name node1 \
 --peer-id "7Xhw2mDxuDS44j42TCB6U5579esbSt3Lg" \
 --message-op=16 \
@@ -787,7 +787,7 @@ cli
 ```sh
 avalanche-network-runner control start \
   --log-level debug \
-  --endpoint="0.0.0.0:8080" \
+  --endpoint="localhost:8080" \
   --number-of-nodes=5 \
   --blockchain-specs '[{"vm_name": "subnetevm", "genesis": "./path/to/config.json"}]'
 ```

scripts/tests.e2e.sh

@@ -146,7 +146,7 @@ echo "running e2e tests"
 --ginkgo.v \
 --ginkgo.fail-fast \
 --log-level debug \
---grpc-endpoint="0.0.0.0:8080" \
---grpc-gateway-endpoint="0.0.0.0:8081" \
+--grpc-endpoint="localhost:8080" \
+--grpc-gateway-endpoint="localhost:8081" \
 --avalanchego-path-1=${VERSION_1_DIR}/avalanchego \
 --avalanchego-path-2=${VERSION_2_DIR}/avalanchego

server/server.go

@@ -176,7 +176,7 @@ func (s *server) Run(rootCtx context.Context) (err error) {
 			ctx, cancel := context.WithTimeout(rootCtx, s.cfg.DialTimeout)
 			gwConn, err := grpc.DialContext(
 				ctx,
-				"0.0.0.0"+s.cfg.Port,
+				"localhost"+s.cfg.Port,
 				grpc.WithBlock(),
 				grpc.WithTransportCredentials(insecure.NewCredentials()),
 			)

tests/e2e/e2e_test.go

@@ -121,13 +121,13 @@ func init() {
 	flag.StringVar(
 		&gRPCEp,
 		"grpc-endpoint",
-		"0.0.0.0:8080",
+		"localhost:8080",
 		"gRPC server endpoint",
 	)
 	flag.StringVar(
 		&gRPCGatewayEp,
 		"grpc-gateway-endpoint",
-		"0.0.0.0:8081",
+		"localhost:8081",
 		"gRPC gateway endpoint",
 	)
 	flag.StringVar(