Merge pull request #687 from ava-labs/allow-remote-api-calls-on-container

allow remote api calls if inside a docker container

Author: felipemadero

local/network.go

@@ -1139,6 +1139,16 @@ func (ln *localNetwork) buildArgs(
 		config.BootstrapIDsKey: ln.bootstraps.IDsArg(),
 	}
 
+	insideContainer, err := utils.IsInsideDockerContainer()
+	if err != nil {
+		return buildArgsReturn{}, err
+	}
+	if insideContainer {
+		// mapped localhost requests (eg using -p flag of docker run) are seen as coming from an external IP like 172.17.0.1
+		// so inside docker container just accept all requests
+		flags[config.HTTPHostKey] = ""
+	}
+
 	// Write staking key/cert etc. to disk so the new node can use them,
 	// and get flag that point the node to those files
 	fileFlags, err := writeFiles(ln.networkID, ln.genesis, dataDir, nodeConfig)

utils/utils.go

@@ -18,6 +18,7 @@ import (
 const (
 	genesisNetworkIDKey = "networkID"
 	dirTimestampFormat  = "20060102_150405"
+	dockerEnvPath       = "/.dockerenv"
 )
 
 var (
@@ -140,3 +141,18 @@ func VerifySubnetHasCorrectParticipants(
 	}
 	return false
 }
+
+func IsInsideDockerContainer() (bool, error) {
+	return PathExists(dockerEnvPath)
+}
+
+func PathExists(path string) (bool, error) {
+	_, err := os.Stat(path)
+	if err != nil {
+		if errors.Is(err, fs.ErrNotExist) {
+			return false, nil
+		}
+		return false, err
+	}
+	return true, nil
+}