Skip to content

Commit 46f6a2e

Browse files
authored
uncomment flakey test (#272)
1 parent c51edee commit 46f6a2e

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

replication_test.go

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,6 @@ func TestReplicationStuckInProposingBlock(t *testing.T) {
723723
// have a stale notarization for a round(i.e. a node notarized a block but the rest of the network
724724
// propagated an empty notarization).
725725
func TestReplicationNodeDiverges(t *testing.T) {
726-
t.Skip("flaky test, should re-enable with the fix for https://github.com/ava-labs/Simplex/issues/262")
727726
nodes := []simplex.NodeID{{1}, {2}, {3}, {4}, {5}, {6}}
728727
numBlocks := uint64(5)
729728

@@ -807,7 +806,19 @@ func TestReplicationNodeDiverges(t *testing.T) {
807806
}
808807

809808
net.Connect(laggingNode.E.ID)
810-
net.TriggerLeaderBlockBuilder(numBlocks + 1)
809+
810+
for _, n := range net.Instances {
811+
// TODO: remove when replication can be initiated with empty notarizations
812+
if n.E.ID.Equals(laggingNode.E.ID) {
813+
continue
814+
}
815+
WaitToEnterRound(t, n.E, numBlocks+1)
816+
}
817+
818+
// we are in round 6(which means node 1 should be leader(but it is blacklisted))
819+
net.AdvanceWithoutLeader(startTimes, 1+numBlocks, laggingNode.E.ID)
820+
821+
net.TriggerLeaderBlockBuilder(numBlocks + 2)
811822
for _, n := range net.Instances {
812823
n.Storage.WaitForBlockCommit(numBlocks - missedSeqs + 1)
813824
}

0 commit comments

Comments
 (0)