Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #69

Closed
maximilianreimer opened this issue Mar 12, 2021 · 8 comments
Closed

Tests are failing #69

maximilianreimer opened this issue Mar 12, 2021 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maximilianreimer
Copy link
Contributor

Some tests are currently failing. Locally on my machine as well as on the gi CI.

There are two kinds of reasons for test failures:

  1. The MNIST Data is not available (any more?). This causes the tests TestSGDEnv::test_get_default_state, est_sgd.py::TestSGDEnv::test_reset and TestSGDEnv::test_stepto fail.
HTTP Error 503: Service Unavailable

/opt/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/urllib/request.py:650: HTTPError
----------------------------- Captured stdout call -----------------------------
Downloading http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz to ../data/MNIST/raw/train-images-idx3-ubyte.gz
  1. The other test that is failing is the fast-downward benchmark, where a time out is received from local server.
...
self = <socket.socket fd=15, family=AddressFamily.AF_INET, type=2049, proto=0, laddr=('0.0.0.0', 54412)>

    def accept(self):
        """accept() -> (socket object, address info)
    
        Wait for an incoming connection.  Return a new socket
        representing the connection, and the address of the client.
        For IP sockets, the address info is a pair (hostaddr, port).
        """
>       fd, addr = self._accept()
E       socket.timeout: timed out

/opt/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/socket.py:205: timeout

For more details see the CI Run and the corresponding test-report

@maximilianreimer maximilianreimer added the bug Something isn't working label Mar 12, 2021
@maximilianreimer maximilianreimer added this to the 0.0.1 milestone Mar 12, 2021
@maximilianreimer
Copy link
Contributor Author

@TheEimer any ideas why 2. is happening?

@maximilianreimer
Copy link
Contributor Author

I reckon 1. is just a temporary issue.

@TheEimer
Copy link
Contributor

None at all, especially since it works for me locally. Probably an issue installing fd? Do you know if that's done properly here (pulling the submodule and the running install in that folder)? That's my only idea so far. It's unfortunately pretty hard to debug the port communication setup...

@maximilianreimer
Copy link
Contributor Author

Yea, I am pretty sure, that that is not the issue. At least I am doing those two steps

@TheEimer
Copy link
Contributor

I was already afraid of that... As it only happens in the scenario tests, though, there is another possibility of the ports overlapping after one test has finished. There could also be a mistake in the scenarios, I'll double check.

@TheEimer
Copy link
Contributor

I think I found the mistake, the absolute fd path in the scenarios refers to my home dir... so I'll fix that and also the onell error.

@TheEimer
Copy link
Contributor

It seems like the absolute path wasn't the issue after all, so maybe it's the port overlap. I'll change what is tested here then, because we want to test the loading here, no tthe integrity of the configs anyway.
Also the cloudflare protection is still a problem, I'll try another workabround I found, but apparently it could cause actual problems with sgd

@TheEimer
Copy link
Contributor

I propose to close this because everything but this has been resolved: #63
Objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants