Skip to content

Commit 671465e

Browse files
committed
fix(json): Backwards compatible loading with "q"
Please see issue: #325
1 parent e121227 commit 671465e

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

ConfigSpace/read_and_write/json.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
487487
lower=hyperparameter["lower"],
488488
upper=hyperparameter["upper"],
489489
default_value=hyperparameter["default"],
490-
q=hyperparameter["q"],
490+
# Backwards compatibily issue
491+
# https://github.com/automl/ConfigSpace/issues/325
492+
q=hyperparameter.get("q", None),
491493
)
492494

493495
if hp_type == "normal_float":
@@ -499,7 +501,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
499501
lower=hyperparameter["lower"],
500502
upper=hyperparameter["upper"],
501503
default_value=hyperparameter["default"],
502-
q=hyperparameter["q"],
504+
# Backwards compatibily issue
505+
# https://github.com/automl/ConfigSpace/issues/325
506+
q=hyperparameter.get("q", None),
503507
)
504508

505509
if hp_type == "beta_float":
@@ -510,7 +514,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
510514
lower=hyperparameter["lower"],
511515
upper=hyperparameter["upper"],
512516
log=hyperparameter["log"],
513-
q=hyperparameter["q"],
517+
# Backwards compatibily issue
518+
# https://github.com/automl/ConfigSpace/issues/325
519+
q=hyperparameter.get("q", None),
514520
default_value=hyperparameter["default"],
515521
)
516522

@@ -521,7 +527,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
521527
lower=hyperparameter["lower"],
522528
upper=hyperparameter["upper"],
523529
default_value=hyperparameter["default"],
524-
q=hyperparameter["q"],
530+
# Backwards compatibily issue
531+
# https://github.com/automl/ConfigSpace/issues/325
532+
q=hyperparameter.get("q", None),
525533
)
526534

527535
if hp_type == "normal_int":
@@ -533,7 +541,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
533541
lower=hyperparameter["lower"],
534542
upper=hyperparameter["upper"],
535543
default_value=hyperparameter["default"],
536-
q=hyperparameter["q"],
544+
# Backwards compatibily issue
545+
# https://github.com/automl/ConfigSpace/issues/325
546+
q=hyperparameter.get("q", None),
537547
)
538548

539549
if hp_type == "beta_int":
@@ -544,7 +554,9 @@ def _construct_hyperparameter(hyperparameter: dict) -> Hyperparameter: # noqa:
544554
lower=hyperparameter["lower"],
545555
upper=hyperparameter["upper"],
546556
log=hyperparameter["log"],
547-
q=hyperparameter["q"],
557+
# Backwards compatibily issue
558+
# https://github.com/automl/ConfigSpace/issues/325
559+
q=hyperparameter.get("q", None),
548560
default_value=hyperparameter["default"],
549561
)
550562

0 commit comments

Comments
 (0)