From cec9c55198be7a2a773f2506a02e178ec46eb173 Mon Sep 17 00:00:00 2001 From: Mari Date: Tue, 7 Nov 2023 11:09:57 +0100 Subject: [PATCH 1/3] add missing feature flag to opentelemetry_otlp for otel-http-push-exporter --- autometrics/Cargo.toml | 3 ++- autometrics/src/otel_push_exporter.rs | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/autometrics/Cargo.toml b/autometrics/Cargo.toml index ecdf880..e495969 100644 --- a/autometrics/Cargo.toml +++ b/autometrics/Cargo.toml @@ -40,7 +40,8 @@ otel-push-exporter = [ "opentelemetry_sdk", "opentelemetry_api", "opentelemetry-otlp", - "opentelemetry-otlp/tls-roots", + "opentelemetry-otlp/metrics", + "opentelemetry-otlp/tls-roots" ] otel-push-exporter-http = [ diff --git a/autometrics/src/otel_push_exporter.rs b/autometrics/src/otel_push_exporter.rs index a475e7e..3a7ca59 100644 --- a/autometrics/src/otel_push_exporter.rs +++ b/autometrics/src/otel_push_exporter.rs @@ -1,8 +1,7 @@ use opentelemetry_api::metrics::MetricsError; use opentelemetry_otlp::{ExportConfig, Protocol, WithExportConfig}; -use opentelemetry_otlp::{OtlpMetricPipeline, OTEL_EXPORTER_OTLP_TIMEOUT_DEFAULT}; +use opentelemetry_otlp::OtlpMetricPipeline; use opentelemetry_sdk::metrics::MeterProvider; -use opentelemetry_sdk::runtime; use std::ops::Deref; use std::time::Duration; From d654f0182189012ce3f008f9b36c790f12af703e Mon Sep 17 00:00:00 2001 From: Mari Date: Tue, 7 Nov 2023 11:11:53 +0100 Subject: [PATCH 2/3] update changelog and rustfmt --- CHANGELOG.md | 2 ++ autometrics/src/otel_push_exporter.rs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c32153..d62eacb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add support for tracing-opentelemetry v0.21 (#147) - Error messages when using `#[autometrics]` together with `#[async_trait]` has been improved (#149) +- Fixed missing feature flag for `opentelemetry-otlp` when autometrics feature + `otel-push-exporter-http` is enabled ## [0.6.0](https://github.com/autometrics-dev/autometrics-rs/releases/tag/v0.5.0) - 2023-08-08 diff --git a/autometrics/src/otel_push_exporter.rs b/autometrics/src/otel_push_exporter.rs index 3a7ca59..2b4fb05 100644 --- a/autometrics/src/otel_push_exporter.rs +++ b/autometrics/src/otel_push_exporter.rs @@ -1,6 +1,6 @@ use opentelemetry_api::metrics::MetricsError; -use opentelemetry_otlp::{ExportConfig, Protocol, WithExportConfig}; use opentelemetry_otlp::OtlpMetricPipeline; +use opentelemetry_otlp::{ExportConfig, Protocol, WithExportConfig}; use opentelemetry_sdk::metrics::MeterProvider; use std::ops::Deref; use std::time::Duration; From ea39d4d762adece8cab6883c1d331569c7836b72 Mon Sep 17 00:00:00 2001 From: Mari Date: Tue, 7 Nov 2023 14:12:52 +0100 Subject: [PATCH 3/3] pr review --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d62eacb..d9f8212 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Error messages when using `#[autometrics]` together with `#[async_trait]` has been improved (#149) - Fixed missing feature flag for `opentelemetry-otlp` when autometrics feature - `otel-push-exporter-http` is enabled + `otel-push-exporter` is enabled ## [0.6.0](https://github.com/autometrics-dev/autometrics-rs/releases/tag/v0.5.0) - 2023-08-08