-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default function enhancements #127
Conversation
Adding flag forceDefault to force the default to be used all the time. Adding dev dependency to automatically download local dynamo. Adding grunt task to start/stop local dynamo instance. Adding tests to support changes.
Awesome! Thanks for adding the test case. Can you update the README and then I'll merge. I also like the addition to the gruntfile. We can use this to replace the travisci logic. |
I'll update the readme and travis file. I wanted to gauge your reaction to the changes to the grunt file as I was considering making the local dynamo tasks automatic when running the tests. That way it's even simpler for a dev to start working on this project. |
Removing travis lines for starting local dynamo. Updating readme with information about default and forceDefault improvements. Commenting out some extra verbose code.
Haven't had time to really dig in to the travis ci failure, but we may need to add the .launch(8000, null, ['-inMemory']) |
Need to take some time to reproduce these failures in various versions of node. |
I fixed some test case errors and now this PR is passing. Are you good with me merging it? |
I'm good with merging. I was seeing some odd errors but it looks like you handled it. |
Making the model get passed to attribute's default function.
Adding flag forceDefault to force the default to be used all the time.
Adding dev dependency to automatically download local dynamo.
Adding grunt task to start/stop local dynamo instance.
Adding tests to support changes.
closes #124