Skip to content

fix(ci): extract npm pack tarball name from final stdout line #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
namastex888 merged 1 commit into from
May 7, 2026
Merged

fix(ci): extract npm pack tarball name from final stdout line #1690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,13 @@ jobs:
- name: Pack release tarball
id: pack
run: |
# npm pack writes the tarball to CWD and prints its filename to stdout.
# --silent suppresses the progress banner that would otherwise pollute
# the step output value.
TARBALL=$(npm pack --silent)
# npm pack writes the tarball name to stdout as its final line, but
# the prepack hook (`bun run build`) ALSO writes to stdout (build
# banner + bundled-assets table). `--silent` only suppresses npm's
# own progress banner, not the prepack hook's output. Capturing
# the full stdout therefore yields a multi-line blob ending with
# the tarball name; `tail -n1` extracts the filename reliably.
TARBALL=$(npm pack --silent | tail -n1)

@chatgpt-codex-connector chatgpt-codex-connector Bot May 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve npm pack exit status in tarball capture

TARBALL=$(npm pack --silent | tail -n1) masks failures from npm pack because this workflow step does not set shell: bash, so the default non-Windows shell runs without pipefail and the pipeline status is taken from tail. That means an npm pack error can be treated as success if tail exits 0 and ${TARBALL} still points to an existing file, allowing the release job to continue from a failed pack operation. Capture npm pack output without a pipeline (or enable pipefail) so pack failures still stop the workflow.

Useful? React with 👍 / 👎.

if [ -z "${TARBALL}" ] || [ ! -f "${TARBALL}" ]; then
echo "npm pack produced no tarball" >&2
exit 1
Expand Down
Loading