Add option to put a ds: prefix to signature fields, to not envelop the signature, and to put the signature after the issuer #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We added an option called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML v2.0 XSD specifies that the signature fields should be prefixed with ds:
https://docs.oasis-open.org/security/saml/v2.0/saml-schema-protocol-2.0.xsd
I've added an option that adds this prefix to all of the signature fields.
I've also added an option to not envelop the signature, and to instead have both a signed assertion and a signed message. I've also put the signature after the Issuer field to match the specification.