Allow custom headers in request #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
suggested changes
Feb 4, 2019
README.md
Outdated
| @@ -13,7 +13,8 @@ const jwksClient = require('jwks-rsa'); | |||
|
|
|||
| const client = jwksClient({ | |||
| strictSsl: true, // Default value | |||
| jwksUri: 'https://sandrino.auth0.com/.well-known/jwks.json' | |||
| jwksUri: 'https://sandrino.auth0.com/.well-known/jwks.json', | |||
| headers: {} // Optional | |||
There was a problem hiding this comment.
Suggested change
| headers: {} // Optional | |
| requestHeaders: {} // Optional |
src/JwksClient.js
Outdated
| @@ -24,7 +24,7 @@ export class JwksClient { | |||
|
|
|||
| getKeys(cb) { | |||
| this.logger(`Fetching keys from '${this.options.jwksUri}'`); | |||
| request({ json: true, uri: this.options.jwksUri, strictSSL: this.options.strictSsl }, (err, res) => { | |||
| request({ json: true, uri: this.options.jwksUri, strictSSL: this.options.strictSsl, headers: this.options.headers }, (err, res) => { | |||
There was a problem hiding this comment.
Suggested change
| request({ json: true, uri: this.options.jwksUri, strictSSL: this.options.strictSsl, headers: this.options.headers }, (err, res) => { | |
| request({ json: true, uri: this.options.jwksUri, strictSSL: this.options.strictSsl, headers: this.options.requestHeaders }, (err, res) => { |
tests/jwksClient.tests.js
Outdated
|
|
||
| const client = new JwksClient({ | ||
| jwksUri: `${jwksHost}/.well-known/jwks.json`, | ||
| headers: { |
There was a problem hiding this comment.
Suggested change
| headers: { | |
| requestHeaders: { |
O-Mutt
force-pushed
the
customHeaders
branch
2 times, most recently
from
85514c0 to
e6b75bb
Compare
…nfirming they are sent with the request
lbalmaceda
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Add-on to #64